From 0a660a1a3852da0e636c0d4e094d63bb970561b9 Mon Sep 17 00:00:00 2001 From: raghavSharmaSigmoid <88667094+raghavSharmaSigmoid@users.noreply.github.com> Date: Fri, 29 Oct 2021 22:43:17 +0530 Subject: [PATCH] fix: Updated connection string for Firebolt (#17242) * New branch from superset for integration with firebolt sqlalchemy adapter * Added db_engine_spec file for Firebolt * Removed firebolt code from superset repo * Deleted virtual env commit * Adding time grain changes to firebolt.py * Updated README.md Added steps to install and run Superset with Firebolt SQLAlchemy Adapter * Update README.md Reduced installation steps. Using PyPi installation for adapter now * Revert "Update README.md" This reverts commit 5ed17c7a4545998ed07693c93738ebe7bff2580e. * Revert "Updated README.md" This reverts commit 45c5072649a7926fc4d15d2eb0b9cc5a89e5d7b2. * added epoch methods, added test cases for firebolt db engine spec and edited setup.py * Added license to files * Added documentation for Firebolt-SQLAlchemy * Removed trailing whitespace * Updated connection string for Firebolt Co-authored-by: apurva-sigmoid <89530372+apurva-sigmoid@users.noreply.github.com> Co-authored-by: Apurva Anand --- docs/src/pages/docs/Connecting to Databases/firebolt.mdx | 8 ++++++-- docs/src/pages/docs/Connecting to Databases/index.mdx | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/docs/src/pages/docs/Connecting to Databases/firebolt.mdx b/docs/src/pages/docs/Connecting to Databases/firebolt.mdx index c1d11ff10e3be..39ef6c8a233b3 100644 --- a/docs/src/pages/docs/Connecting to Databases/firebolt.mdx +++ b/docs/src/pages/docs/Connecting to Databases/firebolt.mdx @@ -14,11 +14,15 @@ Superset has been tested on `firebolt-sqlalchemy>=0.0.1`. The recommended connection string is: ``` -firebolt://{username}:{password}@{host}/{database} +firebolt://{username}:{password}@{database} +or +firebolt://{username}:{password}@{database}/{engine_name} ``` Here's a connection string example of Superset connecting to a Firebolt database: ``` -firebolt://email@domain:password@host/sample_database +firebolt://email@domain:password@sample_database +or +firebolt://email@domain:password@sample_database/sample_engine ``` diff --git a/docs/src/pages/docs/Connecting to Databases/index.mdx b/docs/src/pages/docs/Connecting to Databases/index.mdx index 5d7ec9f38e237..d2d2cd6a77eba 100644 --- a/docs/src/pages/docs/Connecting to Databases/index.mdx +++ b/docs/src/pages/docs/Connecting to Databases/index.mdx @@ -42,7 +42,7 @@ A list of some of the recommended packages. |[Elasticsearch](/docs/databases/elasticsearch)|```pip install elasticsearch-dbapi```|```elasticsearch+http://{user}:{password}@{host}:9200/```| |[Exasol](/docs/databases/exasol)|```pip install sqlalchemy-exasol```|```exa+pyodbc://{username}:{password}@{hostname}:{port}/my_schema?CONNECTIONLCALL=en_US.UTF-8&driver=EXAODBC```| |[Google Sheets](/docs/databases/google-sheets)|```pip install shillelagh[gsheetsapi]```|```gsheets://```| -|[Firebolt](/docs/databases/firebolt)|```pip install firebolt-sqlalchemy```|```firebolt://{username}:{password}@{host}/{database}```| +|[Firebolt](/docs/databases/firebolt)|```pip install firebolt-sqlalchemy```|```firebolt://{username}:{password}@{database} or firebolt://{username}:{password}@{database}/{engine_name}```| |[Hologres](/docs/databases/hologres)|```pip install psycopg2```|```postgresql+psycopg2://:@/```| |[IBM Db2](/docs/databases/ibm-db2)|```pip install ibm_db_sa```|```db2+ibm_db://```| |[IBM Netezza Performance Server](/docs/databases/netezza)|```pip install nzalchemy```|```netezza+nzpy://:@/```|