From 0b05c27bcc328f7a3fdeaa6018f572ddf2a40163 Mon Sep 17 00:00:00 2001 From: Grace Date: Fri, 6 Aug 2021 15:17:51 -0700 Subject: [PATCH] fix comments --- superset/models/dashboard.py | 5 ----- superset/views/dashboard/mixin.py | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/superset/models/dashboard.py b/superset/models/dashboard.py index 4b5a294fc6ad6..d74efa72cde8f 100644 --- a/superset/models/dashboard.py +++ b/superset/models/dashboard.py @@ -161,11 +161,6 @@ class Dashboard( # pylint: disable=too-many-instance-attributes def __repr__(self) -> str: return f"Dashboard<{self.id or self.slug}>" - @property - def table_names(self) -> str: - # pylint: disable=no-member - return ", ".join(str(s.datasource.full_name) for s in self.slices) - @property def url(self) -> str: return f"/superset/dashboard/{self.slug or self.id}/" diff --git a/superset/views/dashboard/mixin.py b/superset/views/dashboard/mixin.py index e0658220671d3..77748fdc3b105 100644 --- a/superset/views/dashboard/mixin.py +++ b/superset/views/dashboard/mixin.py @@ -39,7 +39,7 @@ class DashboardMixin: # pylint: disable=too-few-public-methods "json_metadata", "published", ] - show_columns = edit_columns + ["table_names", "charts"] + show_columns = edit_columns + ["charts"] search_columns = ("dashboard_title", "slug", "owners", "published") add_columns = edit_columns base_order = ("changed_on", "desc")