From 0e0e7dac80686f12e11ad9d4684e419bde644a5f Mon Sep 17 00:00:00 2001
From: Beto Dealmeida <roberto@dealmeida.net>
Date: Tue, 30 May 2023 12:38:01 -0700
Subject: [PATCH] chore: tests for #24249

---
 superset-frontend/src/dashboard/util/permissionUtils.test.ts | 1 -
 superset-frontend/src/dashboard/util/permissionUtils.ts      | 2 +-
 superset-frontend/src/types/Owner.ts                         | 2 --
 3 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/superset-frontend/src/dashboard/util/permissionUtils.test.ts b/superset-frontend/src/dashboard/util/permissionUtils.test.ts
index d19b048769ecb..7ebf0362d2220 100644
--- a/superset-frontend/src/dashboard/util/permissionUtils.test.ts
+++ b/superset-frontend/src/dashboard/util/permissionUtils.test.ts
@@ -61,7 +61,6 @@ const owner: Owner = {
   first_name: 'Test',
   id: ownerUser.userId!,
   last_name: 'User',
-  username: ownerUser.username,
 };
 
 const sqlLabUser: UserWithPermissionsAndRoles = {
diff --git a/superset-frontend/src/dashboard/util/permissionUtils.ts b/superset-frontend/src/dashboard/util/permissionUtils.ts
index 6a218349b2f94..c07f0bb0f8df7 100644
--- a/superset-frontend/src/dashboard/util/permissionUtils.ts
+++ b/superset-frontend/src/dashboard/util/permissionUtils.ts
@@ -50,7 +50,7 @@ export const canUserEditDashboard = (
 ) =>
   isUserWithPermissionsAndRoles(user) &&
   (isUserAdmin(user) || isUserDashboardOwner(dashboard, user)) &&
-  findPermission('can_write', 'Dashboard', user.roles);
+  findPermission('can_write', 'Dashboard', user?.roles);
 
 export function canUserAccessSqlLab(
   user?: UserWithPermissionsAndRoles | UndefinedUser,
diff --git a/superset-frontend/src/types/Owner.ts b/superset-frontend/src/types/Owner.ts
index b7548ec629003..91e9d29c9bf94 100644
--- a/superset-frontend/src/types/Owner.ts
+++ b/superset-frontend/src/types/Owner.ts
@@ -25,6 +25,4 @@ export default interface Owner {
   first_name: string;
   id: number;
   last_name: string;
-  username: string;
-  email?: string;
 }