From 20259fe8e442dace8d83ad9f2df20b82e20b7597 Mon Sep 17 00:00:00 2001 From: Kamil Gabryjelski Date: Thu, 17 Sep 2020 15:48:40 +0200 Subject: [PATCH] Add null checks --- superset-frontend/src/SqlLab/components/LimitControl.tsx | 2 +- superset-frontend/src/components/DeleteModal.tsx | 2 +- superset-frontend/src/datasource/ChangeDatasourceModal.tsx | 2 +- .../src/explore/components/PropertiesModal.tsx | 6 +++--- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/superset-frontend/src/SqlLab/components/LimitControl.tsx b/superset-frontend/src/SqlLab/components/LimitControl.tsx index fcebd3b0aeabe..8dabab4746162 100644 --- a/superset-frontend/src/SqlLab/components/LimitControl.tsx +++ b/superset-frontend/src/SqlLab/components/LimitControl.tsx @@ -115,7 +115,7 @@ export default class LimitControl extends React.PureComponent< event: React.FormEvent, ) => this.setState({ - textValue: (event.currentTarget.value as string) ?? '', + textValue: (event.currentTarget?.value as string) ?? '', }) } /> diff --git a/superset-frontend/src/components/DeleteModal.tsx b/superset-frontend/src/components/DeleteModal.tsx index c465a5d4a4daa..6e2bc90901b07 100644 --- a/superset-frontend/src/components/DeleteModal.tsx +++ b/superset-frontend/src/components/DeleteModal.tsx @@ -73,7 +73,7 @@ export default function DeleteModal({ onChange={( event: React.FormEvent, ) => { - const targetValue = (event.currentTarget.value as string) ?? ''; + const targetValue = (event.currentTarget?.value as string) ?? ''; setDisableChange(targetValue.toUpperCase() !== 'DELETE'); }} /> diff --git a/superset-frontend/src/datasource/ChangeDatasourceModal.tsx b/superset-frontend/src/datasource/ChangeDatasourceModal.tsx index ee1d8ce497410..b5895c122beb9 100644 --- a/superset-frontend/src/datasource/ChangeDatasourceModal.tsx +++ b/superset-frontend/src/datasource/ChangeDatasourceModal.tsx @@ -117,7 +117,7 @@ const ChangeDatasourceModal: FunctionComponent = ({ const changeSearch = ( event: React.FormEvent, ) => { - setFilter((event.currentTarget.value as string) ?? ''); + setFilter((event.currentTarget?.value as string) ?? ''); }; return ( diff --git a/superset-frontend/src/explore/components/PropertiesModal.tsx b/superset-frontend/src/explore/components/PropertiesModal.tsx index 7d0fecdfdc147..c1e7777f88f17 100644 --- a/superset-frontend/src/explore/components/PropertiesModal.tsx +++ b/superset-frontend/src/explore/components/PropertiesModal.tsx @@ -177,7 +177,7 @@ function PropertiesModal({ slice, onHide, onSave }: InternalProps) { value={name} onChange={( event: React.FormEvent, - ) => setName((event.currentTarget.value as string) ?? '')} + ) => setName((event.currentTarget?.value as string) ?? '')} /> @@ -191,7 +191,7 @@ function PropertiesModal({ slice, onHide, onSave }: InternalProps) { onChange={( event: React.FormEvent, ) => - setDescription((event.currentTarget.value as string) ?? '') + setDescription((event.currentTarget?.value as string) ?? '') } style={{ maxWidth: '100%' }} /> @@ -215,7 +215,7 @@ function PropertiesModal({ slice, onHide, onSave }: InternalProps) { event: React.FormEvent, ) => { const targetValue = - (event.currentTarget.value as string) ?? ''; + (event.currentTarget?.value as string) ?? ''; setCacheTimeout(targetValue.replace(/[^0-9]/, '')); }} />