From 41bbf62e586933172bde4b4080a4f21fe1ccd290 Mon Sep 17 00:00:00 2001 From: mohittt8 Date: Fri, 17 Jun 2022 05:13:17 +0530 Subject: [PATCH] fix(presto): use correct timespec for presto (#20333) --- superset/db_engine_specs/presto.py | 2 +- tests/unit_tests/db_engine_specs/test_presto.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/superset/db_engine_specs/presto.py b/superset/db_engine_specs/presto.py index 9a72b76081658..d0621e288ef41 100644 --- a/superset/db_engine_specs/presto.py +++ b/superset/db_engine_specs/presto.py @@ -761,7 +761,7 @@ def convert_dttm( utils.TemporalType.TIMESTAMP, utils.TemporalType.TIMESTAMP_WITH_TIME_ZONE, ): - return f"""TIMESTAMP '{dttm.isoformat(timespec="microseconds", sep=" ")}'""" + return f"""TIMESTAMP '{dttm.isoformat(timespec="milliseconds", sep=" ")}'""" return None @classmethod diff --git a/tests/unit_tests/db_engine_specs/test_presto.py b/tests/unit_tests/db_engine_specs/test_presto.py index 512d03096b0b9..228427c9caa76 100644 --- a/tests/unit_tests/db_engine_specs/test_presto.py +++ b/tests/unit_tests/db_engine_specs/test_presto.py @@ -30,17 +30,17 @@ ( "TIMESTAMP", datetime(2022, 1, 1, 1, 23, 45, 600000), - "TIMESTAMP '2022-01-01 01:23:45.600000'", + "TIMESTAMP '2022-01-01 01:23:45.600'", ), ( "TIMESTAMP WITH TIME ZONE", datetime(2022, 1, 1, 1, 23, 45, 600000), - "TIMESTAMP '2022-01-01 01:23:45.600000'", + "TIMESTAMP '2022-01-01 01:23:45.600'", ), ( "TIMESTAMP WITH TIME ZONE", datetime(2022, 1, 1, 1, 23, 45, 600000, tzinfo=pytz.UTC), - "TIMESTAMP '2022-01-01 01:23:45.600000+00:00'", + "TIMESTAMP '2022-01-01 01:23:45.600+00:00'", ), ], )