From 73c6abde5e25d2f65e4cdfbed5cdcc9b0ab7c123 Mon Sep 17 00:00:00 2001
From: Maxime Beauchemin <maximebeauchemin@gmail.com>
Date: Wed, 24 Jan 2024 12:27:48 -0800
Subject: [PATCH] fix(docker): credentials issues around superset-cache in
 forks (#26772)

---
 .github/workflows/docker.yml | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml
index 5aa2040c2aa28..1a43ffdde3bd2 100644
--- a/.github/workflows/docker.yml
+++ b/.github/workflows/docker.yml
@@ -15,18 +15,20 @@ jobs:
     steps:
       - name: "Check for secrets"
         id: check
-        shell: bash
+        env:
+          DOCKERHUB_USER: ${{ secrets.DOCKERHUB_USER }}
+          DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
         run: |
-          if [ -n "${{ (secrets.DOCKERHUB_USER != '' && secrets.DOCKERHUB_TOKEN != '') || '' }}" ]; then
-            echo "has-secrets=1" >> "$GITHUB_OUTPUT"
+          if [[ -n "$DOCKERHUB_USER" && -n "$DOCKERHUB_TOKEN" ]]; then
+            echo "has-secrets=true" >> "$GITHUB_ENV"
             echo "has secrets!"
           else
-            echo "has-secrets=0" >> "$GITHUB_OUTPUT"
+            echo "has-secrets=false" >> "$GITHUB_ENV"
             echo "no secrets!"
           fi
   docker-build:
     needs: config
-    if: needs.config.outputs.has-secrets
+    if: needs.config.outputs.has-secrets == 'true'
     name: docker-build
     runs-on: ubuntu-latest
     strategy: