From 95cdda4482c76b9bb6578fbe8862c8b0b1421787 Mon Sep 17 00:00:00 2001 From: Mars Date: Tue, 18 Dec 2018 09:03:51 +0800 Subject: [PATCH] Fix string value displaying NaN (#6534) --- superset/assets/src/visualizations/Table/Table.js | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/superset/assets/src/visualizations/Table/Table.js b/superset/assets/src/visualizations/Table/Table.js index 23cdc07d3ba41..e8742afb170c9 100644 --- a/superset/assets/src/visualizations/Table/Table.js +++ b/superset/assets/src/visualizations/Table/Table.js @@ -174,7 +174,15 @@ function TableVis(element, props) { return null; }) .classed('text-right', d => d.isMetric) - .attr('title', d => (!Number.isNaN(d.val) ? formatValue(d.val) : null)) + .attr('title', (d) => { + if (typeof d.val === 'string') { + return d.val; + } + if (!Number.isNaN(d.val)) { + return formatValue(d.val); + } + return null; + }) .attr('data-sort', d => (d.isMetric) ? d.val : null) // Check if the dashboard currently has a filter for each row .classed('filtered', d =>