From a422c765c7601058e13dcf50d5251a166d542aec Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Nikola=20Gigi=C4=87?= <nik.gigic@gmail.com>
Date: Wed, 20 Jan 2021 07:17:56 +0100
Subject: [PATCH] chore(chart): Save modal select placeholder value (#12413)

* Fix SaveModal select value

* var name change and null

* Address Comments
---
 .../src/explore/components/SaveModal.tsx              | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/superset-frontend/src/explore/components/SaveModal.tsx b/superset-frontend/src/explore/components/SaveModal.tsx
index e079b1a2b0078..5450094285c26 100644
--- a/superset-frontend/src/explore/components/SaveModal.tsx
+++ b/superset-frontend/src/explore/components/SaveModal.tsx
@@ -158,6 +158,11 @@ class SaveModal extends React.Component<SaveModalProps, SaveModalState> {
   }
 
   render() {
+    const dashboardSelectValue =
+      this.state.saveToDashboardId || this.state.newDashboardName;
+    const valueObj = dashboardSelectValue
+      ? { value: dashboardSelectValue }
+      : null;
     return (
       <StyledModal
         show
@@ -248,15 +253,13 @@ class SaveModal extends React.Component<SaveModalProps, SaveModalState> {
             <CreatableSelect
               id="dashboard-creatable-select"
               className="save-modal-selector"
+              menuPosition="fixed"
               options={this.props.dashboards}
               clearable
               creatable
               onChange={this.onDashboardSelectChange}
               autoSize={false}
-              value={{
-                value:
-                  this.state.saveToDashboardId || this.state.newDashboardName,
-              }}
+              value={valueObj}
               placeholder={
                 // Using markdown to allow for good i18n
                 <ReactMarkdown