From af8fefc63cc1a41f0cbed6d462c8e204c3cf2894 Mon Sep 17 00:00:00 2001 From: Jack Fragassi Date: Thu, 3 Aug 2023 13:03:12 -0700 Subject: [PATCH] Fix tests --- .../0769ef90fddd_fix_schema_perm_for_datasets__tests.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/integration_tests/migrations/0769ef90fddd_fix_schema_perm_for_datasets__tests.py b/tests/integration_tests/migrations/0769ef90fddd_fix_schema_perm_for_datasets__tests.py index 19d6d0e6035d2..1b74a7f04869a 100644 --- a/tests/integration_tests/migrations/0769ef90fddd_fix_schema_perm_for_datasets__tests.py +++ b/tests/integration_tests/migrations/0769ef90fddd_fix_schema_perm_for_datasets__tests.py @@ -21,6 +21,7 @@ from superset import db from superset.connectors.sqla.models import SqlaTable from superset.models.slice import Slice +from superset.utils.core import backend, get_example_default_schema from tests.integration_tests.fixtures.birth_names_dashboard import ( load_birth_names_dashboard_with_slices, load_birth_names_data, @@ -37,6 +38,9 @@ @pytest.mark.usefixtures("load_birth_names_dashboard_with_slices") def test_fix_schema_perm(): + if backend() == "sqlite": + return + dataset = db.session.query(SqlaTable).filter_by(table_name="birth_names").one() chart = db.session.query(Slice).filter_by(slice_name="Girls").one() dataset.schema_perm = "wrong" @@ -45,8 +49,8 @@ def test_fix_schema_perm(): fix_datasets_schema_perm(db.session) db.session.commit() - assert dataset.schema_perm == "[examples].[public]" + assert dataset.schema_perm == f"[examples].[{get_example_default_schema()}]" fix_charts_schema_perm(db.session) db.session.commit() - assert chart.schema_perm == "[examples].[public]" + assert chart.schema_perm == f"[examples].[{get_example_default_schema()}]"