From b6feb95fa95e2c72234d51c2f2fcde9ff813a45c Mon Sep 17 00:00:00 2001
From: Jesse Yang <jesse.yang@airbnb.com>
Date: Mon, 22 Feb 2021 15:54:29 -1000
Subject: [PATCH] test: use data-test for testIdAttribute

---
 superset-frontend/spec/helpers/setup.ts                 | 2 +-
 superset-frontend/src/components/ModalTrigger/index.jsx | 8 ++------
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/superset-frontend/spec/helpers/setup.ts b/superset-frontend/spec/helpers/setup.ts
index 6218cd6b9daae..28abd96bc5c25 100644
--- a/superset-frontend/spec/helpers/setup.ts
+++ b/superset-frontend/spec/helpers/setup.ts
@@ -21,5 +21,5 @@ import './shim';
 import { configure as configureTestingLibrary } from '@testing-library/react';
 
 configureTestingLibrary({
-  testIdAttribute: 'data-test-id',
+  testIdAttribute: 'data-test',
 });
diff --git a/superset-frontend/src/components/ModalTrigger/index.jsx b/superset-frontend/src/components/ModalTrigger/index.jsx
index 882142fca62f7..d374e9e26e775 100644
--- a/superset-frontend/src/components/ModalTrigger/index.jsx
+++ b/superset-frontend/src/components/ModalTrigger/index.jsx
@@ -91,7 +91,7 @@ export default class ModalTrigger extends React.Component {
         <>
           <Button
             className="modal-trigger"
-            data-test-id="btn-modal-trigger"
+            data-test="btn-modal-trigger"
             tooltip={this.props.tooltip}
             onClick={this.open}
           >
@@ -104,11 +104,7 @@ export default class ModalTrigger extends React.Component {
     /* eslint-disable jsx-a11y/interactive-supports-focus */
     return (
       <>
-        <span
-          data-test-id="span-modal-trigger"
-          onClick={this.open}
-          role="button"
-        >
+        <span data-test="span-modal-trigger" onClick={this.open} role="button">
           {this.props.triggerNode}
         </span>
         {this.renderModal()}