diff --git a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx index c58b3d382e6d7..bfffe94b2a5cc 100644 --- a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx +++ b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx @@ -20,7 +20,7 @@ import React, { useCallback, useMemo, useState } from 'react'; import Tabs from 'src/components/Tabs'; import Button from 'src/components/Button'; -import { NativeSelect as Select } from 'src/components/Select'; +import { Select } from 'src/components'; import { t, styled } from '@superset-ui/core'; import { Form, FormItem } from 'src/components/Form'; @@ -126,17 +126,8 @@ const ColumnSelectPopover = ({ selectedCalculatedColumn?.column_name !== initialCalculatedColumn?.column_name || selectedSimpleColumn?.column_name !== initialSimpleColumn?.column_name; - - const filterOption = useCallback( - (input, option) => - option?.filterBy.toLowerCase().indexOf(input.toLowerCase()) >= 0, - [], - ); - - const getPopupContainer = useCallback( - (triggerNode: any) => triggerNode.parentNode, - [], - ); + const savedExpressionsLabel = t('Saved expressions'); + const simpleColumnsLabel = t('Column'); return (
@@ -147,56 +138,44 @@ const ColumnSelectPopover = ({ allowOverflow > - + - {calculatedColumns.map(calculatedColumn => ( - + options={calculatedColumns.map(calculatedColumn => ({ + value: calculatedColumn.column_name, + label: + calculatedColumn.verbose_name || calculatedColumn.column_name, + customLabel: ( - - ))} - + ), + key: calculatedColumn.column_name, + }))} + /> - + + ), + key: simpleColumn.column_name, + }))} + />