Type filter in Dataset CRUD view doesn't work

[etr2460]

When I select "Physical" as the dataset type I still get virtual datasets

Expected results

Only get physical dataset types

Actual results

Also get virtual datasets

Screenshots

[issue-label-bot]

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.95. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[dpgaspar]

@etr2460 I'm not being able to reproduce this. The filter applies to is_sqllab_view

[nytai]

I'm also unable to reproduce. @etr2460 are some of these datasets using the native druid connector? It's possible the logic that determines the datasets type is incorrectly implemented for druid datasources. As @dpgaspar mentioned the actual filtering logic is applied to the is_sqllab_view attribute.

[etr2460]

@dpgaspar, @nytai: I can still repro this, even with Presto datasources. However, it looks like the ones that get filtered as Physical but are labeled as Virtual have custom sql added to them. Perhaps that needs to be part of the filtering logic too?

[nytai]

@etr2460 is the issue here that physical datasets are incorrectly labelled as virtual, or that the filter logic is not accounting for other instances/types of virtual datasets?

[etr2460]

I think it's the latter. The datasets seem to be correctly labeled as Virtual, but they still show up when you filter to Physical only datasets

[nytai]

ok, I see what the discrepancy is here. The label of "Physical" and "Virtual" is based on the presence of the sql attribute (see https://github.com/apache/incubator-superset/blob/155b5edec131d71eb392ee52f9bf97de495c2ef0/superset/connectors/base/models.py#L116). Meanwhile the filter for "Physical" and "Virtual" is based on the is_sqllab_view flag (see https://github.com/apache/incubator-superset/blob/155b5edec131d71eb392ee52f9bf97de495c2ef0/superset-frontend/src/views/CRUD/data/dataset/DatasetList.tsx#L353).

So the question is, which attribute determines if it's a "virtual" dataset? The presence of the sql attribute or the is_sqllab_view attribute?

[nytai]

hmmm, looks like is_sqllab_view only exists for sqla datasources

[nytai]

@etr2460 can you confirm this was fixed by #11452 when you get a chance?