Use database_name in share query link

[vera-liu]

No description provided.

[mistercrunch]

Careful here, there's no guarantee that a database name is unique. It'd be great to have a meaningful/readable yet unique ID for databases.

[bkyryliuk]

@mistercrunch - can't we just enforce the DB name to be unique?
Do you have any user flow where it would make sense to have multiple DBs with the same name ?

[xrmx]

@bkyryliuk multiple database with the same name on different datasources does not look that unusual

[mistercrunch]

I vote for adding a new field database_id that would be unique, non-null and based off of the database_name. No spaces or special character.

That would require a migration script that kickstarts the field and suffix number are added where there is uniqueness conflict on the "slugified" database name.

A utils.slugify(name, model_column) method could be generalized and reused wherever we need this.

[bkyryliuk]

@vera-liu - could u tackle it this week ?

[vera-liu]

Since we use shortened link now, this issue is out of scope, closing for now.