Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL lab]Strange horizontal scrolling on SqlLab table #13817

Closed
3 tasks done
michael-s-molina opened this issue Mar 26, 2021 · 4 comments
Closed
3 tasks done

[SQL lab]Strange horizontal scrolling on SqlLab table #13817

michael-s-molina opened this issue Mar 26, 2021 · 4 comments
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed sqllab Namespace | Anything related to the SQL Lab

Comments

@michael-s-molina
Copy link
Member

michael-s-molina commented Mar 26, 2021

Look at this video:

screen-recording-2021-03-26-at-30623-pm_B6McZtxJ.mov

At the beginning of the video, you can see that the last column requires horizontal scrolling but none is available. The user cannot see all the data. This is happening because the horizontal scroll is being applied to the page and not to the table like Explore. When the tabs require more space, then the horizontal scroll appears on the page, but as a result, the buttons disappear to the right.

Probably related with #13789

Expected results

Horizontal scrolling is applicable to the table and not the page. Similar to Explore.

How to reproduce the bug

  1. Go to SqlLab
  2. Select many tables
  3. Watch the scroll behavior

@junlincc

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@michael-s-molina michael-s-molina added the #bug Bug report label Mar 26, 2021
@junlincc junlincc changed the title Strange horizontal scrolling on SqlLab table [SQL lab]Strange horizontal scrolling on SqlLab table Mar 27, 2021
@junlincc junlincc added #bug:cosmetic Cosmetic/layout/design tweak needed sqllab Namespace | Anything related to the SQL Lab and removed #bug Bug report Turing labels Mar 27, 2021
@junlincc
Copy link
Member

Thanks for reporting!
@AAfghahi @eschutho could we push a fix for this issue? 🙏

@eschutho
Copy link
Member

Thanks @junlincc, yes, we’ll take a look at this and the other one. @yousoph

@yousoph
Copy link
Member

yousoph commented Apr 5, 2021

@michael-s-molina are you still seeing the issue with not being able to see the last column? I'm still seeing that the save button is getting pushed off to the side when there are a lot of preview tabs open, but can't repro the column getting cut off anymore.

@michael-s-molina
Copy link
Member Author

@yousoph The issue with the last column has been resolved on master. Only the buttons problem remaining.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed sqllab Namespace | Anything related to the SQL Lab
Projects
None yet
Development

No branches or pull requests

4 participants