Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing dataset to change database it points on #15733

Closed
helo-ch opened this issue Jul 16, 2021 · 9 comments
Closed

Editing dataset to change database it points on #15733

helo-ch opened this issue Jul 16, 2021 · 9 comments
Assignees
Labels
#bug Bug report data:databases Related to database configurations and connections validation:validated A committer has validated / submitted the issue or it was reported by multiple users

Comments

@helo-ch
Copy link

helo-ch commented Jul 16, 2021

We use several Timescale DB databases.
Some tables have been migrated from one DB (DB1) to another (DB2).
There are datasets pointing on tables from DB1, that we would like to edit to point on DB2.

Expected results

The Dataset editing window seemingly allows us to edit the Database, schema and table, so that we could edit a dataset to point on a table from DB2 rather than from DB1.

superset_edit_dataset_window

Actual results

But when we click save on that window, nothing happens and the dataset is unchanged, it still points to the same table from DB1. We tried syncing columns from datasource before saving, the result is still the same.
It doesn't seem to be linked to roles or permissions, as it happens even with admin role.

To clarify, table name and table schema are the same in DB1 and DB2, the only part that we need to change is the Database.

Environment

(please complete the following information):

  • superset version: 1.0.1

Is it possible to edit a dataset to point on a table from a different database? If it is not possible, it should be made clearer in the editing window.

@helo-ch helo-ch added the #bug Bug report label Jul 16, 2021
@srinify
Copy link
Contributor

srinify commented Jul 20, 2021

hey @junlincc if I squint, I believe this issue was mentioned / fixed in the last month or 2 right? Or am I mis-remembering

@CollinKendor
Copy link

I am experiencing the same issue in the dockerized version of superset. Is there any fix to the docker version?

@CollinKendor
Copy link

@srinify i can't find any other mention of this in the issue list.

@cccs-tom
Copy link
Contributor

I just experienced this as well On Superset 1.2.0. The UI reports that the changes were saved successfully, but nothing actually changes. I checked the logs and I see no errors.

@igudav
Copy link

igudav commented Jan 28, 2022

Same issue on dockered version 1.2.0

@srinify srinify added data:databases Related to database configurations and connections validation:validated A committer has validated / submitted the issue or it was reported by multiple users labels Mar 16, 2022
@vnktsh
Copy link

vnktsh commented Mar 17, 2022

I have same issue, both in New and LegacyDataEditor.

@rusackas
Copy link
Member

@cccs-tom / @hughhhh are either of you able to confirm/deny whether or not #17265 does indeed effectively close this, or if there are more nuances that need to be dealt with here?

@cccs-tom
Copy link
Contributor

@rusackas I just re-tested this and it seems to work as expected. Unfortunately, I can't remember the exact scenario I encountered (in July 2021) which prompted me to add my +1 to this bug report! But it looks fixed to me!

@rusackas
Copy link
Member

Well that's great news! Closing it out then, but happy to revisit if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report data:databases Related to database configurations and connections validation:validated A committer has validated / submitted the issue or it was reported by multiple users
Projects
None yet
Development

No branches or pull requests

8 participants