Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide creation button when not having creation rights #17088

Closed
DBouwmans opened this issue Oct 13, 2021 · 1 comment
Closed

Hide creation button when not having creation rights #17088

DBouwmans opened this issue Oct 13, 2021 · 1 comment
Labels
enhancement:request Enhancement request submitted by anyone from the community

Comments

@DBouwmans
Copy link

Problem description
As a user of superset, with rights to only view existing dashboards, I would expect not to see the + dashboard buttons. Currently, the + dashboard button provides an error that the user doesn’t have the rights to create a dashboard, but I want to hide the button instead of providing this error.

This is exactly the same for creating dashboards and queries. I don’t want the ReadOnly end users to see the creation buttons. The fact that they can click on it makes it confusing to them.

Current situation

  • Still able to click on add dashboard/chart/SQL query when they don’t have the rights to do so. When they do, the following error ‘Access is Denied’ appears

image
image

  • Same applies to the + buttons on the main page.
  • The user is still able to view the ‘Mine’ tabs (which is unnecessary, since they can’t have dashboards of their own since they don’t have the rights)

image

Desired solution

  • There are no + buttons for creation actions a user doesn’t have the rights for (in the menu bar or on the home page)
  • The ‘Mine’ tabs are no longer visible when the user doesn’t have the rights for creating that object.
  • For queries, the whole part of saved queries could be deleted since you can only view your own. However, I know that a functionality to favorite queries is requested/being developed so I would understand the choice to not do this.

Describe alternatives you've considered
This couldn’t be successfully resolved in css because it only relates to specific roles, others should still be able to view the + Dashboard button when they do have a role with these rights.

Additional context
Please let me know if this feature request requires any additional information

@rosemarie-chiu
Copy link
Contributor

rosemarie-chiu commented Oct 22, 2021

I believe this PR: #17157 help solved the top navigation + button part. cc @hughhhh

@geido geido added the enhancement:request Enhancement request submitted by anyone from the community label Jan 26, 2022
@apache apache locked and limited conversation to collaborators Feb 2, 2022
@geido geido converted this issue into discussion #18516 Feb 2, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement:request Enhancement request submitted by anyone from the community
Projects
None yet
Development

No branches or pull requests

3 participants