Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation line chart color cannot be changed #19299

Closed
ghost opened this issue Mar 22, 2022 · 5 comments
Closed

Annotation line chart color cannot be changed #19299

ghost opened this issue Mar 22, 2022 · 5 comments
Labels
#bug Bug report explore:annotation Related to annotations in Explore validation:required A committer should validate the issue viz:charts:echarts Related to Echarts

Comments

@ghost
Copy link

ghost commented Mar 22, 2022

When use line chart as an annotation, I cannot set color of the annotation.

How to reproduce the bug

  1. Go to Explore Chart, chart type select Time-series line chart
  2. Click on Annotation Layers
  3. In Edit Annotation Layer, select Time Series as layer type, Line Chart as Annotation Source, select a Line chart.
  4. In Display Configuration, choose a color, click Apply and Run Query
  5. See error, annotation color is not changed

Expected results

The annotation color is as you choose

Actual results

The color never change to your selected color

Screenshots

annotation_color_setting_not_working_Trim.mp4

Environment

  • browser type and version: Chrome Version 99.0.4844.51 (Official Build) (64-bit)
  • superset version: 1.4.0
@ghost ghost added the #bug Bug report label Mar 22, 2022
@srinify srinify added validation:required A committer should validate the issue explore:annotation Related to annotations in Explore labels Mar 23, 2022
@zuzana-vej zuzana-vej added the viz:charts:echarts Related to Echarts label Apr 11, 2022
@zuzana-vej
Copy link
Contributor

We have gotten different but potentially related bug reported; Specifically on e-chart time series chart. When there are multiple annotation lines, users can't define the colors (not even in dashboard metadata). This seems like a feature parity before migration to e-charts.
Screen Shot 2022-04-11 at 2 46 06 PM
Screen Shot 2022-04-11 at 2 46 11 PM

@ghost
Copy link
Author

ghost commented Apr 13, 2022

Thank you for your reply. Actually I was using only one single line not multiple lines in the annotation. And all other configuration like Style, Opacity, Width can work just except for Color. So shall I wait for further update on the migration?

@zuzana-vej
Copy link
Contributor

@fuxiaodun maybe someone else is better to answer your question (not me) - I just reported similar. bug basically commenting here instead of opening new ticket.

@yousoph? I know this is echart related - any right person to tag here?

@stephenLYZ
Copy link
Member

stephenLYZ commented Apr 18, 2022

@fuxiaodun @zuzana-vej Hi, late to the party. I have opened a PR to fix this issue. And please feel free to @ me If you have any questions about echart.

@rusackas
Copy link
Member

Looks like this issue didn't get closed with the linked/merged PR. Closing, but holler if this needs a revisit for any lingering issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report explore:annotation Related to annotations in Explore validation:required A committer should validate the issue viz:charts:echarts Related to Echarts
Projects
None yet
Development

No branches or pull requests

4 participants