Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branding favicon is not used on all page #21494

Closed
enzo-dechaene opened this issue Sep 16, 2022 · 0 comments · Fixed by #21498
Closed

Branding favicon is not used on all page #21494

enzo-dechaene opened this issue Sep 16, 2022 · 0 comments · Fixed by #21498
Labels
#bug Bug report

Comments

@enzo-dechaene
Copy link

Hello,

I had replaced the FAVICONS parameter in the config.py file.

FAVICONS = [{"href": "/static/assets/images/my-favicon.png"}]

It seems to work on all pages except :

  • login page
  • 404, 500 error pages
  • Security pages (list users, list roles, row level security, action log)

image

It seems that the path to the superset favicon is still used in the project, it should use the FAVICONS parameter.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant