Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear all button is clearing required filters out of scope and preventing users from applying new filter combination #24496

Closed
3 tasks done
yousoph opened this issue Jun 23, 2023 · 0 comments · Fixed by #24610
Assignees
Labels

Comments

@yousoph
Copy link
Member

yousoph commented Jun 23, 2023

It's possible to map dashboard filters to specific tabs, so that they don't appear when viewing tabs they are not mapped to (they are considered out of scope).
When hitting CLEAR ALL, required filters out of scope are also getting cleared, preventing the user from applying a new filter selection.

How to reproduce the bug

  1. Create a chart, and save to a dashboard.
  2. Create a second chart and save it to the same dashboard
  3. Edit the dashboard, and add two tabs to it.
  4. Add one chart to each tab.
  5. Create two dashboard filters, make them required and map one for each tab.
  6. When viewing a particular tab, click on CLEAR ALL.
  7. Apply a new value for the only required filter for this tab.

Expected results

The user is able to apply the new filter combination, given there's only one required filter for this tab.
Required highlights should be removed for out of scope filters

Actual results

The user is blocked from applying a new filter combination, unless all required filters (from all tabs) are re-filled.

Screenshots

image

Environment

(please complete the following information):

  • browser type and version:
  • superset version: master
  • python version: python --version
  • node.js version: node -v
  • any feature flags active:

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants