Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL lab shows invalid date for Started column in Query History #24790

Closed
2 of 3 tasks
mdeshmu opened this issue Jul 25, 2023 · 5 comments · Fixed by #25133
Closed
2 of 3 tasks

SQL lab shows invalid date for Started column in Query History #24790

mdeshmu opened this issue Jul 25, 2023 · 5 comments · Fixed by #25133
Assignees

Comments

@mdeshmu
Copy link
Contributor

mdeshmu commented Jul 25, 2023

A clear and concise description of what the bug is.

How to reproduce the bug

  1. Go to 'SQL Lab' and run a query
  2. Click on the 'Query History' tab
  3. Look at the values of to 'Started' column
  4. See the "Invalid date" written

Expected results

proper time should be shown as per the current code

Actual results

"invalid date" is shown

Screenshots

image

Environment

(please complete the following information):

  • browser type and version: Chrome and Mozilla
  • superset version: 3.0.0.rc1
  • python version: 3.9.x
  • node.js version: NA
  • any feature flags active: NA

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for Python stack traces and included them here as text if there are any.
  • I have reproduced the issue with at least the latest released version of the superset.
  • I have checked the issue tracker for the same issue and haven't found one similar.

Additional context

NA

@mdeshmu
Copy link
Contributor Author

mdeshmu commented Jul 25, 2023

The current code only shows time which is not useful if we want to see queries more than a day old.
While fixing this, request to add the date as well in the output.

@michael-s-molina
Copy link
Member

@justinpark Could you take a look at this?

@justinpark
Copy link
Member

@mdeshmu could you test with latest 3.0? I don't see the same problem with the latest 3.0
_DEV__Superset

@justinpark
Copy link
Member

@mdeshmu could you share the startDttm value in your bootstrap data by

const appContainer = document.getElementById('app');
const dataBootstrap = appContainer?.getAttribute('data-bootstrap');
JSON.parse(dataBootstrap)

_DEV__Superset

@zhaorui2022
Copy link
Contributor

I also run into this issue and I am on 3.0.0rc3. however, when trying to inspect the bootstrap data, it seems the structure is different than the one in the screenshot above.

Screenshot 2023-08-30 at 1 11 50 PM

And for our case, it is only happening to the successful queries, not the failed ones.
Screenshot 2023-08-30 at 1 04 57 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants