Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIP] Add Atgenomix SeqsLab data engine to Superset supported database. #25093

Closed
allen-chang opened this issue Aug 27, 2023 · 3 comments
Closed
Labels
data:connect Namespace | Anything related to db connections / integrations

Comments

@allen-chang
Copy link

[SIP] Proposal for adding Atgenomix SeqsLab data engine to Superset supported database

Motivation

Atgenomix SeqsLab allows its users to use Superset to on-demand access and visualize their omics databases stored in data lake.

Proposed Change

Add documentation in the list of supported databases and dependencies.
https://superset.apache.org/docs/databases/installing-database-drivers/

Screen Shot 2023-08-27 at 9 21 41 AM

New or Changed Public Interfaces

SeqsLab db engine spec

New dependencies

The SeqsLab Connector for Python based on pyhive

Migration Plan and Compatibility

N/A

Rejected Alternatives

N/A

@allen-chang allen-chang added the sip Superset Improvement Proposal label Aug 27, 2023
@betodealmeida
Copy link
Member

This is nice! In my opinion we don't need a SIP for this, since it doesn't affect any public interfaces or major features. And even though it introduces a new dependency, DB engine spec dependencies are optional, so it should be fine. You can go ahead an PR it and add me as a reviewer, I'll be happy to take a look.

A few things of notice:

  1. I wrote a tool to test DB engine spec implementations (and SQLAlchemy dialects as well, to make sure they implement everything Superset needs). You can read more about it in feat: command to test DB engine specs #24918.
  2. You have the option of having the DB engine spec be part of Superset, or you can distribute it in a separate package (see an example here and here). Distributing it in a separate package means you can release new versions independently of Superset, which allows people to adopt features more quickly. But the downside is that the DB engine spec interface is not public, so it might change between major versions and break existing 3rd party DB engine specs.

@betodealmeida betodealmeida added data:connect Namespace | Anything related to db connections / integrations and removed sip Superset Improvement Proposal labels Aug 31, 2023
@allen-chang
Copy link
Author

@betodealmeida #25176 please can you review it.

@eschutho
Copy link
Member

Looks like we can close this issue/SIP in favor of the attached PR, but feel free to comment if you think we need to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:connect Namespace | Anything related to db connections / integrations
Projects
None yet
Development

No branches or pull requests

3 participants