You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is nice! In my opinion we don't need a SIP for this, since it doesn't affect any public interfaces or major features. And even though it introduces a new dependency, DB engine spec dependencies are optional, so it should be fine. You can go ahead an PR it and add me as a reviewer, I'll be happy to take a look.
A few things of notice:
I wrote a tool to test DB engine spec implementations (and SQLAlchemy dialects as well, to make sure they implement everything Superset needs). You can read more about it in feat: command to test DB engine specs #24918.
You have the option of having the DB engine spec be part of Superset, or you can distribute it in a separate package (see an example here and here). Distributing it in a separate package means you can release new versions independently of Superset, which allows people to adopt features more quickly. But the downside is that the DB engine spec interface is not public, so it might change between major versions and break existing 3rd party DB engine specs.
[SIP] Proposal for adding Atgenomix SeqsLab data engine to Superset supported database
Motivation
Atgenomix SeqsLab allows its users to use Superset to on-demand access and visualize their omics databases stored in data lake.
Proposed Change
Add documentation in the list of supported databases and dependencies.
https://superset.apache.org/docs/databases/installing-database-drivers/
New or Changed Public Interfaces
SeqsLab db engine spec
New dependencies
The SeqsLab Connector for Python based on pyhive
Migration Plan and Compatibility
N/A
Rejected Alternatives
N/A
The text was updated successfully, but these errors were encountered: