Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIP-106] Adding alternative text or image to charts when they do not return any result #25512

Closed
RaptorRob opened this issue Oct 4, 2023 · 3 comments
Labels
sip Superset Improvement Proposal

Comments

@RaptorRob
Copy link

Please make sure you are familiar with the SIP process documented
(here)[https://github.com//issues/5602]. The SIP will be numbered by a committer upon acceptance.

[SIP] Proposal for alternative text/image for charts not showing any results

Motivation

When a chart is showing no results (for instance as part of filtering) it shows:
image

I think it doesn't make a dashboard look good if some components look like this in case they don't return any results.

Proposed Change

It would be great to show a pre-defined text or an image instead.

@RaptorRob RaptorRob added the sip Superset Improvement Proposal label Oct 4, 2023
@rusackas rusackas changed the title [SIP] Adding alternative text or image to charts when they do not return any result [SIP-106] Adding alternative text or image to charts when they do not return any result Oct 13, 2023
@rusackas
Copy link
Member

rusackas commented Dec 6, 2023

I think we need a little clarity on the proposal.

Do you want to replace this image/text globally (like perhaps something in config.py)?

Or are you hoping to have an extra field in the chart control panel that lets you select customized text and/or image for each chart instantiation when they don't turn up data?

Or is it just a proposal to replace the existing image/text with a different design?

@rusackas
Copy link
Member

rusackas commented Dec 6, 2023

Also, feel free to post this to the dev@superset.apache.org email list if you want to move the process forward, or reach out to me/us on Slack for additional help here.

@rusackas
Copy link
Member

Closing this as discarded... please let us know if you want to move forward with your proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sip Superset Improvement Proposal
Projects
Status: Denied / Closed / Discarded
Development

No branches or pull requests

2 participants