Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superset 3.0.0 generates invalid SQL for Dremio after releasing #23872 #25554

Closed
2 tasks done
OskarNS opened this issue Oct 6, 2023 · 1 comment · Fixed by #25657
Closed
2 tasks done

Superset 3.0.0 generates invalid SQL for Dremio after releasing #23872 #25554

OskarNS opened this issue Oct 6, 2023 · 1 comment · Fixed by #25657
Assignees

Comments

@OskarNS
Copy link
Contributor

OskarNS commented Oct 6, 2023

A clear and concise description of what the bug is.

How to reproduce the bug

  1. Create a new chart that has the options of Series Limit. Eg. Time-Series Chart, Area Chart etc.
  2. Set required fields and Series Limit
  3. Click Create Chart.
  4. See error

Expected results

The chart is shown successfully on the right.

Actual results

Unexpected error returned. Superset generates invalid SQL for Dremio, which then throws an error. See screenshots

Screenshots

image

Comparison of SQL generated for Dremio for a Time series chart in 3.0.0 and 2.1.1, respectively:
image

Environment

  • superset version: 3.0.0

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

This pull request has introduced the regression: #23872
This is also apparent in the above screenshots. The invalid SQL is due to aliases missing.

How should we proceed from there? Should #23872 be reverted?

@michael-s-molina
Copy link
Member

@betodealmeida Could you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants