Sqllab UI regession in 3.0.0 where it's not displaying certain string values

[zhaorui2022]

After we upgraded to 3.0.0, we have received user reporting query results not rendering in sqllab results. I have checked the api call results in network tab and can confirm the correct value has been returned from the backend database. So this seems like an issue with front end.

How to reproduce the bug

1. Go to Sqllab, select any database (I tested this on Presto and MySQL)
2. Run SELECT '<abcdef:12345>' as test_str
3. Run the query
4. See error

Expected results

String values rendered as in 2.0.0

Actual results

String values not being rendered

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

(please complete the following information):

• browser type and version: Chrome latest stable version
• superset version: superset version 3.0.0
• python version: python --version3.9
• node.js version: node -v v20.8.0
• any feature flags active: N/A

Checklist

Make sure to follow these steps before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

[zhaorui2022]

I have taken a look at the code but don't have a clue due to lack of front end code knowledge. @justinpark Do you happen to know what the problem might be?

[bkyryliuk]

probably related code:

superset/superset-frontend/packages/superset-ui-core/src/utils/html.tsx

Line 35 in 1786070

return isProbablyHTML(htmlString) ? sanitizeHtml(htmlString) : htmlString;

See:

superset/superset-frontend/packages/superset-ui-core/src/utils/html.tsx

Line 31 in 1786070

return /<[^>]+>/.test(text);

Effectively it removes all it thinks is html.

[rusackas]

This is still happening on current master. We're open to proposals/PRs to fix this.

[rusackas]

Noting that in the chart builder, unchecking HTML rendering doesn't fix the issue there either.

[rusackas]

I know @mistercrunch has looked at some of this HTML rendering business, just in case he sees any obvious solution here

[mistercrunch]

Recent related feature -> #27969, so it looks like it can be switched off, but given the issue here, better/smarter html detection could help as well. For SQL Lab specifically looks like the flag lives there superset-frontend/src/utils/localStorageHelpers.ts, but idk how these flags get set/managed (?)

[mistercrunch]

For the record I think this is the area that would need to be improved if we wanted to be smarter around detecting html -> https://github.com/apache/superset/blob/master/superset-frontend/packages/superset-ui-core/src/utils/html.tsx#L43-L45