Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In 3.1.0rc3, color rendering of charts displayed in dashboard view is different than color rendering in chart view --regression from 2.1.0 #26321

Closed
3 tasks done
ablanchard opened this issue Dec 20, 2023 · 2 comments

Comments

@ablanchard
Copy link

When displaying charts inside a dashboard the color scheme seems not to be resetted after each chart render. This cause the charts to look different whereas they should be harmonized. When we open the chart individually the bug is not present.
In the steps to reproduce, I am focusing on 1 type of chart but it's something we have noticed on differents type of charts.

How to reproduce the bug

  1. With superset 3.1.0rc3
  2. Go to the USA Births Names dashboard from the examples
  3. Scroll to the 10 girl name share
  4. Notice that there is no red or orange used. Also notice that the girl and the boy charts are using different colors but they should have the same colors used.
usa_names_dashboard_310rc3 5. Go to the chart listing page 6. Search for `10 girl name share` 7. Open it 8. Notice that the chart is displayed with different colors that on the dashboard view including red and orange. 10_girl_chart_310rc3

Expected results

In version 2.1.0
The dashboard, both girl and boy charts are using the same color:
usa_names_dashboard_210

The chart individually:
10_girl_chart_210

Actual results

In 3.1.0rc3
The dashboard, girl and boy charts are using different colors for rendering.
usa_names_dashboard_310rc3

Whereas individually the chart is displayed the same as 2.1.0:
10_girl_chart_310rc3

Environment

(please complete the following information):

  • browser type and version: firefox 120.0.1
  • superset version: 3.1.0rc3 in docker
  • python version: 3.9.18
  • node.js version: node -v
  • any feature flags active:

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@michael-s-molina
Copy link
Member

michael-s-molina commented Dec 21, 2023

Hi @ablanchard. The same chart might be present in multiple dashboards and each dashboard has its own color scheme. Any time you access a chart individually, using the chart list, it won't match the color of any specific dashboard. If your dashboard have a Color Scheme defined, and you access the chart from the dashboard by clicking on Edit Chart, the chart will inherit the same color scheme defined by the dashboard.

Screen.Recording.2023-12-21.at.10.42.13.mov

@ablanchard
Copy link
Author

Thanks @michael-s-molina, you are right this issue is not very related with the bug I'm seeing. I'll try to reproduce it more precisely and maybe create a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants