Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ant Design 5: Upgrade Alert component #30911

Closed
geido opened this issue Nov 13, 2024 · 3 comments · Fixed by #31168
Closed

Ant Design 5: Upgrade Alert component #30911

geido opened this issue Nov 13, 2024 · 3 comments · Fixed by #31168
Assignees
Labels
frontend:refactor:antd5 preset:bounty:chore Chores that have been selected by Preset and have a bounty attached. preset:bounty Issues that have been selected by Preset and have a bounty attached.

Comments

@geido
Copy link
Member

geido commented Nov 13, 2024

Please refer to SIP-139 #29268.

The Alert component should be upgraded to Ant Design version 5.

Similar work has been completed here.

When upgrading the component to Ant Design 5, please ensure to include:

  • Proper RTL test coverage if not present yet.
  • A Storybook file (if not present) or all necessary changes.
  • Include all relevant component options in the Storybook.
  • Clean up unnecessary custom styles.

When opening a PR:

  • Name your PR refactor({Component}): Upgrade {component} to Ant Design 5
  • Add screenshots of BEFORE/AFTER in your PR.
  • Update the project tracker when your PR is merged.
  • Make sure you or a committer has labeled your PR with frontend:refactor:antd5.
@geido geido added preset:bounty Issues that have been selected by Preset and have a bounty attached. preset:bounty:chore Chores that have been selected by Preset and have a bounty attached. frontend:refactor:antd5 and removed frontend:refactor:antd5 labels Nov 13, 2024
@LevisNgigi
Copy link
Contributor

Hey @geido I would love to work on this

@fardin-developer
Copy link

Hey I am working on this issue, please assign me.

@geido
Copy link
Member Author

geido commented Nov 21, 2024

Hello @fardin-developer feel free to work on issues if you like. However, to be eligible for the Preset bounties, you should be assigned by a bounty manager. It's all explained n the Preset Bounty Program Contribution Guide. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend:refactor:antd5 preset:bounty:chore Chores that have been selected by Preset and have a bounty attached. preset:bounty Issues that have been selected by Preset and have a bounty attached.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@geido @fardin-developer @LevisNgigi and others