Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rison instead of json when encoding form_data in URL #4440

Closed
betodealmeida opened this issue Feb 15, 2018 · 4 comments
Closed

Use rison instead of json when encoding form_data in URL #4440

betodealmeida opened this issue Feb 15, 2018 · 4 comments
Labels
inactive Inactive for >= 30 days

Comments

@betodealmeida
Copy link
Member

Feature suggestion: use rison (https://github.com/pifantastic/python-rison) instead of json when encoding form_data in the URL. Here's a comparison between both:

%7B%22datasource%22%3A%223__table%22%2C%22viz_type%22%3A%22dual_line%22%2C%22slice_id%22%3A21%2C%22granularity_sqla%22%3Anull%2C%22time_grain_sqla%22%3Anull%2C%22since%22%3A%22100+years+ago%22%2C%22until%22%3A%22now%22%2C%22color_scheme%22%3A%22bnbColors%22%2C%22x_axis_format%22%3A%22smart_date%22%2C%22metric%22%3A%22avg__num%22%2C%22y_axis_format%22%3A%22.3s%22%2C%22metric_2%22%3A%22sum__num%22%2C%22y_axis_2_format%22%3A%22.3s%22%2C%22annotation_layers%22%3A%5B%5D%2C%22where%22%3A%22%22%2C%22having%22%3A%22%22%2C%22filters%22%3A%5B%5D%2C%22extra_filters%22%3A%5B%5D%7D
(annotation_layers:!(),color_scheme:bnbColors,datasource:'3__table',extra_filters:!(),filters:!(),granularity_sqla:!n,having:'',metric:avg__num,metric_2:sum__num,since:'100+years+ago',slice_id:21,time_grain_sqla:!n,until:now,viz_type:dual_line,where:'',x_axis_format:smart_date,y_axis_2_format:.3s,y_axis_format:.3s)
@mistercrunch
Copy link
Member

@graceguo-supercat

1 similar comment
@timifasubaa
Copy link
Contributor

timifasubaa commented Mar 5, 2018

@graceguo-supercat

@betodealmeida
Copy link
Member Author

#5152

@stale
Copy link

stale bot commented Apr 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 10, 2019
@stale stale bot closed this as completed Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive Inactive for >= 30 days
Projects
None yet
Development

No branches or pull requests

3 participants