Incorrect SQL statement on "View Query": python-encoded % character (%%) on STR_TO_DATE()

[hajdbo]

Using Mysql engine, the request displayed when clicking "View Query" shows a python-encoded %: %%

The query should have single % characters, rather than %%.

I followed the trail to get_query_str() in https://github.com/apache/incubator-superset/blob/master/superset/connectors/sqla/models.py#L418

• I have checked the superset logs for python stacktraces and included it here as text if any
• I have reproduced the issue with at least the latest released version of superset
• I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

0.24.0

Expected results

The query displayed should be syntactically correct, showing a single % for STR_TO_DATE() function.

Actual results

Steps to reproduce

Use a mysql engine, create a slice with time constraits, click the "View Query" button.

[xrmx]

Symptoms looks very similar to #4830

[villebro]

@hajdbo I can take a look at this in the coming days. Just curious, have you run into this on other database types as well? i don't have a MySQL installation readily at hand, but can set one up if needed. Btw, naming a column "date" seems slightly risky, calling it account_date or similar might save trouble down the road.

[mistercrunch]

Pretty sure this represents the SQL we're sending to the database driver (dbapi) which has its own %-based formatting function. While we know what it receives I don't think we have a handle on its internal formatting function.

[nick-gray]

Is this all related to #4098 ?

We are hitting similar issues where we have to enter %% as a single % fails when executed. The text we enter must also be utf-8 encoded

[xrmx]

This should be fixed in both master and 0.25 branch, please test and close. Thanks!

[hajdbo]

Not fixed in 0.25.4 release with SQLalchemy 1.2.2

[hajdbo]

Seems very closely related to #617

[hajdbo]

Fixed with 0.28 release. Thank you! 👍