Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added parser to parse request referer url for url_param (issue_id : 13315) #13509

Closed
wants to merge 7 commits into from
Closed

fix: added parser to parse request referer url for url_param (issue_id : 13315) #13509

wants to merge 7 commits into from

Conversation

celestialmechanic21
Copy link

@celestialmechanic21 celestialmechanic21 commented Mar 7, 2021

SUMMARY

I have added code to parse request's referer url to get query params for url_param function used is sql editor.
Link to issue

closes #13315

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

Added test case for change

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@celestialmechanic21 celestialmechanic21 changed the title fix:added parser to parse request referer url for url_param (issue_id : 13315) fix: added parser to parse request referer url for url_param (issue_id : 13315) Mar 7, 2021
@codecov
Copy link

codecov bot commented Mar 7, 2021

Codecov Report

Merging #13509 (50b35c5) into master (7b370e6) will decrease coverage by 5.64%.
The diff coverage is 62.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13509      +/-   ##
==========================================
- Coverage   77.22%   71.57%   -5.65%     
==========================================
  Files         912      821      -91     
  Lines       46034    41010    -5024     
  Branches     5587     4227    -1360     
==========================================
- Hits        35549    29353    -6196     
- Misses      10354    11657    +1303     
+ Partials      131        0     -131     
Flag Coverage Δ
cypress 57.45% <53.00%> (-0.12%) ⬇️
hive 80.13% <80.24%> (+0.07%) ⬆️
javascript ?
mysql 80.46% <82.71%> (+0.07%) ⬆️
postgres 80.50% <82.71%> (+0.07%) ⬆️
presto 80.17% <80.24%> (+0.08%) ⬆️
python 81.00% <82.71%> (+0.07%) ⬆️
sqlite 80.12% <79.01%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/common/components/index.tsx 100.00% <ø> (ø)
...-frontend/src/components/AlteredSliceTag/index.jsx 92.00% <ø> (ø)
...rontend/src/components/AsyncEsmComponent/index.tsx 94.11% <ø> (ø)
...ntend/src/components/ConfirmStatusChange/index.tsx 82.60% <ø> (ø)
...dashboard/components/FiltersBadge/DetailsPanel.tsx 51.28% <0.00%> (-10.95%) ⬇️
...hboard/components/nativeFilters/FilterBar/utils.ts 100.00% <ø> (ø)
...tersConfigModal/FiltersConfigForm/ControlItems.tsx 64.28% <ø> (-0.94%) ⬇️
...rc/explore/components/controls/AnnotationLayer.jsx 52.40% <ø> (+1.23%) ⬆️
...rontend/src/filters/components/Range/buildQuery.ts 0.00% <ø> (ø)
...set-frontend/src/filters/components/Range/index.ts 75.00% <ø> (+45.00%) ⬆️
... and 552 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b370e6...619c77d. Read the comment docs.

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Mar 7, 2021
@junlincc junlincc requested a review from robdiciuccio March 10, 2021 05:00
@junlincc junlincc added the new:contributor The author is a new contributor label Mar 10, 2021
@junlincc
Copy link
Member

@robdiciuccio 🙏

@robdiciuccio
Copy link
Member

Thanks for opening a PR @celestialmechanic21!

Rather than relying on the Referer header, it may make more sense to pass the query params directly on the XHR request, as this would be more explicit.

@villebro @dpgaspar @betodealmeida any additional context on this?

@stale
Copy link

stale bot commented Jun 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Jun 11, 2021
@maltoze
Copy link
Contributor

maltoze commented Jun 21, 2021

Opened another pr to fix this. #15246

@stale stale bot removed the inactive Inactive for >= 30 days label Jun 21, 2021
@villebro
Copy link
Member

Closing as this has been superseded by another fix PR.

@villebro villebro closed this Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new:contributor The author is a new contributor size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Use Jinja Context for "url_param"
5 participants