-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added parser to parse request referer url for url_param (issue_id : 13315) #13509
fix: added parser to parse request referer url for url_param (issue_id : 13315) #13509
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13509 +/- ##
==========================================
- Coverage 77.22% 71.57% -5.65%
==========================================
Files 912 821 -91
Lines 46034 41010 -5024
Branches 5587 4227 -1360
==========================================
- Hits 35549 29353 -6196
- Misses 10354 11657 +1303
+ Partials 131 0 -131
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thanks for opening a PR @celestialmechanic21! Rather than relying on the Referer header, it may make more sense to pass the query params directly on the XHR request, as this would be more explicit. @villebro @dpgaspar @betodealmeida any additional context on this? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
Opened another pr to fix this. #15246 |
Closing as this has been superseded by another fix PR. |
SUMMARY
I have added code to parse request's referer url to get query params for
url_param
function used is sql editor.Link to issue
closes #13315
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Added test case for change
ADDITIONAL INFORMATION