From a68d6cf9ce6a24e27ecb773ba407610d98f6af80 Mon Sep 17 00:00:00 2001 From: geido Date: Wed, 24 Mar 2021 18:34:43 +0200 Subject: [PATCH] Add tests --- .../controls/TextControl/TextControl.test.tsx | 102 ++++++++++++++++++ .../index.tsx} | 0 2 files changed, 102 insertions(+) create mode 100644 superset-frontend/src/explore/components/controls/TextControl/TextControl.test.tsx rename superset-frontend/src/explore/components/controls/{TextControl.tsx => TextControl/index.tsx} (100%) diff --git a/superset-frontend/src/explore/components/controls/TextControl/TextControl.test.tsx b/superset-frontend/src/explore/components/controls/TextControl/TextControl.test.tsx new file mode 100644 index 0000000000000..cddb024692143 --- /dev/null +++ b/superset-frontend/src/explore/components/controls/TextControl/TextControl.test.tsx @@ -0,0 +1,102 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import React from 'react'; +import { fireEvent, render, screen } from 'spec/helpers/testing-library'; +import userEvent from '@testing-library/user-event'; +import TextControl from '.'; + +const mockedProps = { + disabled: false, + isFloat: false, + isInt: false, + placeholder: 'Placeholder', + value: 'Sample value', +}; + +test('should render', () => { + const { container } = render(); + expect(container).toBeInTheDocument(); +}); + +test('should render a textbox', () => { + render(); + expect(screen.getByRole('textbox')).toBeInTheDocument(); +}); + +test('should render with initial value', () => { + render(); + expect(screen.getByDisplayValue('Sample value')).toBeInTheDocument(); +}); + +test('should render with placeholder', () => { + render(); + expect(screen.getByPlaceholderText('Placeholder')).toBeInTheDocument(); +}); + +test('should render as disabled', () => { + const disabledProps = { + ...mockedProps, + disabled: true, + }; + render(); + expect(screen.getByPlaceholderText('Placeholder')).toBeDisabled(); +}); + +test('should focus', () => { + const focusProps = { + ...mockedProps, + onFocus: jest.fn(), + }; + render(); + const input = screen.getByPlaceholderText('Placeholder'); + fireEvent.focus(input); + expect(focusProps.onFocus).toHaveBeenCalledTimes(1); +}); + +test('should return errors when not a float', async () => { + const changeProps = { + ...mockedProps, + isFloat: true, + value: null, + onChange: jest.fn(), + }; + render(); + const input = screen.getByPlaceholderText('Placeholder'); + await userEvent.type(input, '!num', { delay: 500 }); + expect(changeProps.onChange).toHaveBeenCalled(); + expect(changeProps.onChange).toHaveBeenCalledWith('!', [ + 'is expected to be a number', + ]); +}); + +test('should return errors when not an int', async () => { + const changeProps = { + ...mockedProps, + isInt: true, + value: null, + onChange: jest.fn(), + }; + render(); + const input = screen.getByPlaceholderText('Placeholder'); + await userEvent.type(input, '!int', { delay: 500 }); + expect(changeProps.onChange).toHaveBeenCalled(); + expect(changeProps.onChange).toHaveBeenCalledWith('!', [ + 'is expected to be an integer', + ]); +}); diff --git a/superset-frontend/src/explore/components/controls/TextControl.tsx b/superset-frontend/src/explore/components/controls/TextControl/index.tsx similarity index 100% rename from superset-frontend/src/explore/components/controls/TextControl.tsx rename to superset-frontend/src/explore/components/controls/TextControl/index.tsx