fix(views/core): iteration over None type

[rasta-rocket]

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[villebro]

I agree with this change (can happen if adhoc_filters is defined but has a value that isn't a list). @rasta-rocket can you update the PR and mark it as non-draft so we can get it merged?

[rasta-rocket]

@villebro done
(thx for relaunching this by the way 😉 )

[codecov]

Codecov Report

Merging #14305 (d9d08d1) into master (c829614) will decrease coverage by 0.12%.
The diff coverage is 49.24%.

❗ Current head d9d08d1 differs from pull request most recent head 547e80b. Consider uploading reports for the commit 547e80b to get more accurate results

@@            Coverage Diff             @@
##           master   #14305      +/-   ##
==========================================
- Coverage   76.94%   76.82%   -0.13%     
==========================================
  Files        1042     1042              
  Lines       56254    56299      +45     
  Branches     7785     7793       +8     
==========================================
- Hits        43286    43250      -36     
- Misses      12710    12793      +83     
+ Partials      258      256       -2     

Flag	Coverage Δ
hive	?
mysql	81.95% <ø> (ø)
postgres	81.96% <ø> (ø)
presto	81.82% <ø> (-0.01%)	⬇️
python	82.22% <ø> (-0.25%)	⬇️
sqlite	81.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ontend/src/SqlLab/components/QuerySearch/index.tsx	76.53% <ø> (ø)
superset-frontend/src/chart/chartAction.js	50.47% <0.00%> (ø)
...rontend/src/components/AsyncEsmComponent/index.tsx	97.29% <ø> (ø)
...rset-frontend/src/components/ErrorMessage/types.ts	100.00% <ø> (ø)
.../ReportModal/HeaderReportActionsDropdown/index.tsx	24.32% <0.00%> (ø)
...ponents/Select/WindowedSelect/WindowedMenuList.tsx	10.71% <ø> (ø)
.../src/components/Select/WindowedSelect/windowed.tsx	88.23% <ø> (ø)
...frontend/src/dashboard/components/Header/index.jsx	68.85% <0.00%> (ø)
...tiveFilters/FiltersConfigModal/FilterTitlePane.tsx	92.00% <0.00%> (ø)
...ntend/src/dashboard/containers/DashboardHeader.jsx	100.00% <ø> (ø)
... and 94 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c829614...547e80b. Read the comment docs.

[villebro]

Thanks @rasta-rocket ! Merging when the last tests pass