Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error mapping in database connection #15504

Merged

Conversation

AAfghahi
Copy link
Member

@AAfghahi AAfghahi commented Jul 1, 2021

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

AAfghahi and others added 26 commits June 11, 2021 12:28
* added alerts

* revisions

* added icon
@AAfghahi AAfghahi changed the base branch from master to pexdax/db-connection-ui July 1, 2021 14:50
@AAfghahi AAfghahi force-pushed the ch18653_errorMapping branch from d4a5d69 to 91abee1 Compare July 1, 2021 15:03
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #15504 (91abee1) into pexdax/db-connection-ui (46621fc) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 91abee1 differs from pull request most recent head f921b12. Consider uploading reports for the commit f921b12 to get more accurate results
Impacted file tree graph

@@                    Coverage Diff                    @@
##           pexdax/db-connection-ui   #15504    +/-   ##
=========================================================
  Coverage                    77.01%   77.02%            
=========================================================
  Files                          975      976     +1     
  Lines                        50882    51168   +286     
  Branches                      6740     6874   +134     
=========================================================
+ Hits                         39189    39412   +223     
- Misses                       11477    11538    +61     
- Partials                       216      218     +2     
Flag Coverage Δ
javascript 71.46% <ø> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/views/CRUD/data/database/DatabaseModal/index.tsx 49.37% <ø> (-25.96%) ⬇️
...nd/src/components/SupersetResourceSelect/index.tsx 70.96% <0.00%> (-12.91%) ⬇️
...c/views/CRUD/data/database/DatabaseModal/styles.ts 86.11% <0.00%> (-11.15%) ⬇️
superset/utils/network.py 25.80% <0.00%> (-9.68%) ⬇️
...nts/controls/DateFilterControl/DateFilterLabel.tsx 57.72% <0.00%> (-8.95%) ⬇️
...mponents/nativeFilters/FiltersConfigModal/utils.ts 67.50% <0.00%> (-7.85%) ⬇️
...RUD/data/database/DatabaseModal/SqlAlchemyForm.tsx 92.30% <0.00%> (-7.70%) ⬇️
superset-frontend/src/views/CRUD/hooks.ts 48.23% <0.00%> (-4.58%) ⬇️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 69.52% <0.00%> (-3.59%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46621fc...f921b12. Read the comment docs.

@hughhhh hughhhh merged commit 1a16c49 into apache:pexdax/db-connection-ui Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants