fix: Read MAPBOX_API_KEY from environment

[Lawful2002]

SUMMARY

This PR fixes: #16781

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

1. Added MAPBOX_API_KEY = get_env_variable("MAPBOX_API_KEY") in superset_config.py
2. added MAPBOX_API_KEY='' in docker/.env and docker/.env-non-dev
3. Updated docs at: https://github.com/apache/superset/blob/a330b664c13e34a4c7ca954f9a3a527a43a5535f/docs/src/pages/docs/frequently-asked-questions-page.mdx#why-is-the-map-not-visible-in-the-geospatial-visualization

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[Lawful2002]

@junlincc Hey, the workflow tests haven't started on their own in a while. Would it be possible to manually start these tests?

[villebro]

@Lawful2002 I closed/reopened the PR, now CI checks seem to have started correctly, sorry for the delay. Will take a look once tests complete.

[riahk]

LGTM once pre-commit is passing!

[jakubczaplicki]

Hey @Lawful2002 , there's only black formatting to fix and this PR can be merged as it's approved. It would be super useful to have it :)

[hbruch]

Is this duplication of https://github.com/apache/superset/blob/master/superset/config.py#L695 required?

[Lawful2002]

I'm not really sure if this duplication is required or not, if I'm being honest. However as the API key is already getting fetched in https://github.com/apache/superset/blob/master/superset/config.py#L695, this duplication may not be required. That said though, the linked issue (#16781) asked MAPBOX_API_KEY = get_env_variable("MAPBOX_API_KEY") to be added to docker/pythonpath_dev/superset_config.py. Also the documentation at https://github.com/apache/superset/blob/a330b664c13e34a4c7ca954f9a3a527a43a5535f/docs/src/pages/docs/frequently-asked-questions-page.mdx#why-is-the-map-not-visible-in-the-geospatial-visualization wants that key in that particular file/location.

[Lawful2002]

Hey @Lawful2002 , there's only black formatting to fix and this PR can be merged as it's approved. It would be super useful to have it :)

I've fixed the formatting. Sorry for the delay

[jakubczaplicki]

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[frafra]

Not stale.

[codecov]

Codecov Report

Merging #16926 (a330b66) into master (c8fe518) will increase coverage by 10.76%.
The diff coverage is n/a.

❗ Current head a330b66 differs from pull request most recent head cf71b04. Consider uploading reports for the commit cf71b04 to get more accurate results

@@             Coverage Diff             @@
##           master   #16926       +/-   ##
===========================================
+ Coverage   66.47%   77.24%   +10.76%     
===========================================
  Files        1727      973      -754     
  Lines       64724    50523    -14201     
  Branches     6822     6184      -638     
===========================================
- Hits        43024    39025     -3999     
+ Misses      19969    11292     -8677     
+ Partials     1731      206     -1525     

Flag	Coverage Δ
hive	81.43% <0.00%> (+27.74%)	⬆️
javascript	71.76% <0.00%> (+20.41%)	⬆️
mysql	81.70% <0.00%> (-0.46%)	⬇️
postgres	81.72% <0.00%> (-0.50%)	⬇️
presto	81.42% <0.00%> (+27.86%)	⬆️
python	82.25% <0.00%> (-0.39%)	⬇️
sqlite	81.36% <0.00%> (-0.60%)	⬇️
unit	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/setup/setupPlugins.ts	0.00% <0.00%> (-100.00%)	⬇️
...-frontend/src/visualizations/presets/MainPreset.js	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/components/Select/Select.tsx	0.00% <0.00%> (-87.29%)	⬇️
...c/visualizations/FilterBox/FilterBoxChartPlugin.js	0.00% <0.00%> (-66.67%)	⬇️
...ntend/src/explore/components/ExploreChartPanel.jsx	16.66% <0.00%> (-57.53%)	⬇️
...tend/src/filters/components/Select/controlPanel.ts	58.33% <0.00%> (-41.67%)	⬇️
superset-frontend/src/utils/hostNamesConfig.js	33.33% <0.00%> (-40.01%)	⬇️
superset/migrations/shared/utils.py	0.00% <0.00%> (-36.18%)	⬇️
...uperset-frontend/src/components/Form/FormLabel.tsx	64.70% <0.00%> (-35.30%)	⬇️
superset-frontend/src/featureFlags.ts	66.66% <0.00%> (-33.34%)	⬇️
... and 1775 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[frafra]

@Lawful2002 there are some conflicts at the moment

[rusackas]

Wow, I'm not sure how this PR fell between the couch cushions for so long, but I'd love to merge this and close the related issue! I'm going to close the PR and re-open it to kick-start the CI process. Then feel free to nag me or others here or on Slack to get this thing merged!