test: added some sanity test for native filter #17231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geido
reviewed
Oct 26, 2021
There was a problem hiding this comment.
Hey @jinghua-qa awesome work that you are doing here! I added some code suggestions for you to review
superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts
Outdated
Show resolved
Hide resolved
superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts
Outdated
Show resolved
Hide resolved
superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts
Outdated
Show resolved
Hide resolved
superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts
Outdated
Show resolved
Hide resolved
jinghua-qa
force-pushed
the
add_native_filter_cypress
branch
from
398c90a to
00b9147
Compare
Codecov Report
@@ Coverage Diff @@
## master #17231 +/- ##
=======================================
Coverage 77.03% 77.03%
=======================================
Files 1037 1037
Lines 55626 55626
Branches 7594 7594
=======================================
Hits 42849 42849
Misses 12527 12527
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
AAfghahi
pushed a commit
that referenced
this pull request
Jan 10, 2022
* add sanity native filter cypress e2e test * add liscense * fix front-end lint * fix fail * remove unuse import
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I added 3 native filter tests for native filter sanity test. Those test are developed by Preset QA group.
1, User can expand / retract native filter sidebar on a dashboard
2,User can enter filter edit pop-up by clicking on pencil icon
3,User can add a new native filter
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION