-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use full resultType with csv download on chart in dashboard #17431
fix: use full resultType with csv download on chart in dashboard #17431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #17431 +/- ##
==========================================
- Coverage 77.04% 77.03% -0.01%
==========================================
Files 1041 1041
Lines 56079 56079
Branches 7742 7742
==========================================
- Hits 43204 43203 -1
- Misses 12617 12618 +1
Partials 258 258
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a follow-up, we should probably reconsider if resultType
should be part of the cache key at all. Potentially we should always cache the full payload, and then only return subsets of if depending on what data the request is expecting.
(cherry picked from commit 71e3fa1)
SUMMARY
Use the full resultType when downloading a csv so that it takes the same cache key as the chart itself. See #17194
This fixes a bug where if you refreshed cache and then downloaded a csv from a dashboard, the csv results would be different than the chart.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
Screen.Recording.2021-11-12.at.5.34.31.PM.mov
TESTING INSTRUCTIONS
We should also test to see that the full csv report download has a row limit.
ADDITIONAL INFORMATION