fix: [alert] should run alert query from report account #17499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graceguo-supercat
force-pushed
the
gg-fixAlertQueryUser
branch
from
a411033 to
4cd7ac3
Compare
Codecov Report
@@ Coverage Diff @@
## master #17499 +/- ##
==========================================
+ Coverage 68.07% 68.13% +0.06%
==========================================
Files 1653 1653
Lines 66374 66375 +1
Branches 7121 7121
==========================================
+ Hits 45181 45224 +43
+ Misses 19296 19254 -42
Partials 1897 1897
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
graceguo-supercat
changed the title
graceguo-supercat
changed the title
|
ping @dpgaspar updated PR with new solution. |
graceguo-supercat
force-pushed
the
gg-fixAlertQueryUser
branch
2 times, most recently
from
e46376a to
a057d1d
Compare
dpgaspar
reviewed
Dec 2, 2021
There was a problem hiding this comment.
This is great @graceguo-supercat. Left a comment, would be nice to add a unittest for get_df to assert the new named parameter username override
superset/reports/commands/alert.py
Outdated
| @@ -146,8 +146,13 @@ def _execute_query(self) -> pd.DataFrame: | |||
| limited_rendered_sql = self._report_schedule.database.apply_limit_to_sql( | |||
| rendered_sql, ALERT_SQL_LIMIT | |||
| ) | |||
| query_username = security_manager.get_user_by_username( | |||
There was a problem hiding this comment.
since get_df accepts a str and get_user_by_username returns a User this call is unnecessary.
graceguo-supercat
force-pushed
the
gg-fixAlertQueryUser
branch
5 times, most recently
from
99f6500 to
96b9eb4
Compare
graceguo-supercat
force-pushed
the
gg-fixAlertQueryUser
branch
from
96b9eb4 to
feeec0a
Compare
graceguo-supercat
force-pushed
the
gg-fixAlertQueryUser
branch
2 times, most recently
from
323f1b8 to
1e5523c
Compare
graceguo-supercat
force-pushed
the
gg-fixAlertQueryUser
branch
from
1e5523c to
83b712e
Compare
|
@dpgaspar Thanks for code review. I fixed your comment and added an integration test. |
dpgaspar
approved these changes
Dec 16, 2021
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
* fix: [alert] should run alert query from report account * add solution2: override username for get_df * add integration test
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
* fix: [alert] should run alert query from report account * add solution2: override username for get_df * add integration test
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When user setup an alert with query and condition, we found that the query was run by
rootuser. It will cause permission issue, since we giveTHUMBNAIL_SELENIUM_USERaccount extra data access, whilerootdoes not.Note, after alert query, the screenshot was taken from
THUMBNAIL_SELENIUM_USERconfig correctly.Proposed solution: set correct username for the alert query.
TESTING INSTRUCTIONS
CI