docs: Oauth_improve

[alejandroparra]

SUMMARY

Hi there!
I was trying to set up the Custom OAuth2 Configuration but found out that one very important and necessary import is missing from the documentation in order to make the sample code work without any problem.

the import missing is with the library OAuth, after several hours of searching and reading found that importing only that library doesn't work, what it works is to import the full OAuth library from flask_appbuilder.security.manager.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue: Documentation update for OAuth configuration #17544
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[villebro]

Thanks for the contribution @alejandroparra - Looks good, but I tagged Daniel for a review, as he has the most context on FAB.

[alejandroparra]

thank you @villebro, is there something else that needs to be done on my end?

[dpgaspar]

Thank you for the PR, this looks good to me. left a non blocking comment, also would you be so kind to update the rest of the example code regarding single quoted and double quotes?

[dpgaspar]

nit: you can just import this one AUTH_OAUTH

[alejandroparra]

hi @dpgaspar thanks for your answer, actually this is exactly the point of my request, I've spent an entire day trying to make the SSO with Google work and all I had to do was add the rest of the libraries in order to make it work, so as is, the current documentation will fail in step to step implementation

[dpgaspar]

That does not make sense to me, why does it fail? do you have the crash log?

[alejandroparra]

It doesn't give a crash log, it just doesn't work, I was trying the OAUTH with google, and didn't authenticate until I added the rest of the dependencies. I've spent about 10 days on that

[dpgaspar]

One final pending question

[rusackas]

If I'm understanding correctly, this PR is hung up over a nit. Can we just resolve the conflicts and merge, or does approval need to be rescinded and more actions taken?

[dpgaspar]

@alejandroparra thank you for the PR, I'm salvaging your contribution on #20640

Just doubled checked FAB by just importing AUTH_OAUTH and found no problems authenticating with Google for example. Feel free to open an issue on FAB or Superset if you need any help