Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(superset-ui): clean up legacy-plugin-chart-time-table #17626

Merged
merged 3 commits into from
Dec 3, 2021

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Dec 1, 2021

SUMMARY

Clean up legacy-plugin-chart-time-table in superset-ui/plugins as it is not actually in use (there is an inline version of this plugin under src/visualizations). Duplicate code is confusing and is causing some build errors in our internal deployment.

Also migrated the src/visualizations version to TypeScript reusing @pkdotson 's work.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #17626 (40639cd) into master (54b56fe) will increase coverage by 0.18%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17626      +/-   ##
==========================================
+ Coverage   68.51%   68.70%   +0.18%     
==========================================
  Files        1602     1595       -7     
  Lines       65344    65170     -174     
  Branches     6992     6943      -49     
==========================================
+ Hits        44770    44774       +4     
+ Misses      18688    18510     -178     
  Partials     1886     1886              
Flag Coverage Δ
javascript 57.44% <0.00%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/visualizations/TimeTable/SparklineCell.tsx 0.00% <ø> (ø)
...c/visualizations/TimeTable/TimeTableChartPlugin.ts 71.42% <ø> (ø)
...end/src/visualizations/TimeTable/transformProps.ts 5.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54b56fe...40639cd. Read the comment docs.

@ktmud ktmud force-pushed the cleanup-time-table-plugin branch from a395e20 to 40639cd Compare December 2, 2021 05:18
@ktmud ktmud requested a review from zhaoyongjie December 2, 2021 07:34
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup

@ktmud ktmud merged commit 73e7928 into apache:master Dec 3, 2021
@john-bodley john-bodley deleted the cleanup-time-table-plugin branch June 8, 2022 05:26
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants