Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(de-translations): Add missing German translations #17693

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

hbruch
Copy link
Contributor

@hbruch hbruch commented Dec 8, 2021

SUMMARY

This PR adds messages which are now extracted from js/ts files again (see #17673).

Note: there are still messages which are not extracted, like e.g. those in superset-frontend/temporary_superset_ui subfolders. Is it intended not to have them extracted by now or should these folders be added to babel.cfg as well?

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

n.a.

TESTING INSTRUCTIONS

  1. add "de": {"flag": "de", "name": "Deutsch"}, to the list of LANGUAGES
  2. start superset an switch to Germann (Deutsch)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #17693 (1622165) into master (b7ae7f9) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 1622165 differs from pull request most recent head b41a9fc. Consider uploading reports for the commit b41a9fc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17693      +/-   ##
==========================================
- Coverage   68.87%   68.83%   -0.05%     
==========================================
  Files        1598     1598              
  Lines       65305    65305              
  Branches     6953     6953              
==========================================
- Hits        44978    44950      -28     
- Misses      18441    18469      +28     
  Partials     1886     1886              
Flag Coverage Δ
hive ?
mysql 82.13% <ø> (ø)
postgres 82.14% <ø> (ø)
presto 82.00% <ø> (?)
python 82.39% <ø> (-0.10%) ⬇️
sqlite 81.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.27% <0.00%> (-16.99%) ⬇️
superset/utils/core.py 89.64% <0.00%> (-0.12%) ⬇️
superset/models/core.py 90.00% <0.00%> (+0.73%) ⬆️
superset/connectors/sqla/models.py 88.20% <0.00%> (+1.12%) ⬆️
superset/db_engine_specs/presto.py 89.97% <0.00%> (+5.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7ae7f9...b41a9fc. Read the comment docs.

@villebro
Copy link
Member

villebro commented Dec 9, 2021

Note: there are still messages which are not extracted, like e.g. those in superset-frontend/temporary_superset_ui subfolders. Is it intended not to have them extracted by now or should these folders be added to babel.cfg as well?

@hbruch the temporary files should not be translated, as they are pieces of code that are in transit (=being moved to the monorepo). Once they land in their final destination they should, however, be extracted.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@villebro villebro merged commit 7192016 into apache:master Dec 10, 2021
@hbruch hbruch deleted the translations_de branch December 21, 2021 17:05
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants