Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: css template API response, less data #17980

Merged
merged 2 commits into from
Jan 10, 2022
Merged

fix: css template API response, less data #17980

merged 2 commits into from
Jan 10, 2022

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jan 10, 2022 •
edited
Loading

SUMMARY

Simplifies and send less unneeded data back, on the CSS template get list REST API

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar requested review from riahk and villebro January 10, 2022 09:39
@codecov
Copy link

codecov bot commented Jan 10, 2022 •
edited
Loading

Codecov Report

Merging #17980 (1640525) into master (ea3a583) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 1640525 differs from pull request most recent head e73c9c3. Consider uploading reports for the commit e73c9c3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17980   +/-   ##
=======================================
  Coverage   67.07%   67.08%           
=======================================
  Files        1609     1611    +2     
  Lines       64903    64919   +16     
  Branches     6868     6871    +3     
=======================================
+ Hits        43535    43548   +13     
- Misses      19502    19504    +2     
- Partials     1866     1867    +1
Flag Coverage Δ
hive 53.29% <ø> (ø)
mysql 82.19% <ø> (ø)
postgres 82.24% <ø> (ø)
presto 53.13% <ø> (ø)
python 82.68% <ø> (ø)
sqlite 81.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../plugins/legacy-preset-chart-nvd3/src/Bar/index.js 66.66% <ø> (ø)
...gins/legacy-preset-chart-nvd3/src/DistBar/index.js 66.66% <ø> (ø)
...ins/legacy-preset-chart-nvd3/src/DualLine/index.js 66.66% <ø> (ø)
...plugins/legacy-preset-chart-nvd3/src/ReactNVD3.jsx 0.00% <ø> (ø)
...ontend/src/dashboard/fixtures/mockNativeFilters.ts 100.00% <ø> (ø)
superset-frontend/src/explore/fixtures.tsx 70.00% <ø> (ø)
superset/css_templates/api.py 95.74% <ø> (ø)
superset-frontend/src/components/Select/Select.tsx 86.42% <100.00%> (+0.09%) ⬆️
...board/components/nativeFilters/FilterBar/index.tsx 82.96% <100.00%> (+0.12%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea3a583...e73c9c3. Read the comment docs.

villebro
villebro approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpgaspar dpgaspar merged commit d35da1f into apache:master Jan 10, 2022
@dpgaspar dpgaspar deleted the fix/api-schema branch January 10, 2022 13:00
rosemarie-chiu pushed a commit to preset-io/superset that referenced this pull request Jan 10, 2022
@dpgaspar @rosemarie-chiu
fix: css template API response, less data (apache#17980)
1436050 
* fix: css template API response, less data

* add test

(cherry picked from commit d35da1f)
@rosemarie-chiu
Copy link
Contributor

🏷 2022.1

eschutho pushed a commit that referenced this pull request Jan 27, 2022
@dpgaspar @eschutho
fix: css template API response, less data (#17980)
dbe0a35 
* fix: css template API response, less data

* add test
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
@dpgaspar @shcoderAlex
fix: css template API response, less data (apache#17980)
719eb72 
* fix: css template API response, less data

* add test
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@dpgaspar @bwang221
fix: css template API response, less data (apache#17980)
4d464f3 
* fix: css template API response, less data

* add test
@mistercrunch mistercrunch added 🍒 1.4.1 🍒 1.4.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

@riahk riahk Awaiting requested review from riahk

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.1 preset-io size/S v1.4.1 🍒 1.4.1 🍒 1.4.2 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dpgaspar @rosemarie-chiu @villebro @mistercrunch @eschutho