-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Assign an owner when creating a dataset from a csv, excel or tabular #17986
fix: Assign an owner when creating a dataset from a csv, excel or tabular #17986
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17986 +/- ##
==========================================
- Coverage 67.10% 66.83% -0.27%
==========================================
Files 1612 1631 +19
Lines 64999 65739 +740
Branches 6872 6872
==========================================
+ Hits 43616 43937 +321
- Misses 19513 19932 +419
Partials 1870 1870
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@villebro I thiiiik you offered some help to write integration tests for that, I would take it! |
@cccs-joel yes, I faintly recall doing that 😄 Let me take a stab at adding a test tomorrow 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the great integration tests!
…ular (apache#17986) * Assign an owner when creating a dataset from a csv, excel or columnar * Added some unit tests * Code cleanup * Removed blank line * Attempt to fix a broken test * Attempt # 2 to fix a broken test * Attempt # 3 to fix a broken test * Attempt # 4 to fix a broken test * Attempt # 5 to fix a broken test * Attempt # 6 to fix a broken test * Broken test fixed, code cleanup
…ular (apache#17986) * Assign an owner when creating a dataset from a csv, excel or columnar * Added some unit tests * Code cleanup * Removed blank line * Attempt to fix a broken test * Attempt # 2 to fix a broken test * Attempt # 3 to fix a broken test * Attempt # 4 to fix a broken test * Attempt # 5 to fix a broken test * Attempt # 6 to fix a broken test * Broken test fixed, code cleanup
…ular (apache#17986) * Assign an owner when creating a dataset from a csv, excel or columnar * Added some unit tests * Code cleanup * Removed blank line * Attempt to fix a broken test * Attempt # 2 to fix a broken test * Attempt # 3 to fix a broken test * Attempt # 4 to fix a broken test * Attempt # 5 to fix a broken test * Attempt # 6 to fix a broken test * Broken test fixed, code cleanup
SUMMARY
The existing code has a bug and no owner gets assigned when a dataset was created from a data upload. The fix assigns the current user as the owner when creating a dataset from a csv, excel or tabular.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION