fix(textarea-control): ace editor input exception #18146
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR is to fix the problem that ace-editor in control panel throws an error when the user typing. The reason for this is that we use an
onChange
callback where the second parameter is an error array by default (see https://github.com/apache/superset/blob/master/superset-frontend/src/explore/components/Control.tsx#L65). But for ace-editor, the second parameter ofonChange
is anevent
, so we need to wrap it to avoid this exception.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
2022-01-23.11.24.18.mov
after
2022-01-23.11.27.18.mov
TESTING INSTRUCTIONS
follow #18094
ADDITIONAL INFORMATION