Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: embedded dashboard #18561

Merged
merged 6 commits into from
Feb 8, 2022
Merged

feat: embedded dashboard #18561

merged 6 commits into from
Feb 8, 2022

Conversation

lilykuang
Copy link
Member

@lilykuang lilykuang commented Feb 2, 2022 •
edited by suddjian
Loading

SUMMARY

Part of #17187

Every dashboard is considered embedded right now. We'll need to change some of the functions in security manager and the dashboard filter. This table is to keep track which dashboard is embedded.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 2, 2022 •
edited
Loading

Codecov Report

Merging #18561 (0481100) into master (85c8d01) will decrease coverage by 0.18%.
The diff coverage is n/a.

❗ Current head 0481100 differs from pull request most recent head 835b30d. Consider uploading reports for the commit 835b30d to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18561      +/-   ##
==========================================
- Coverage   66.30%   66.12%   -0.19%     
==========================================
  Files        1595     1595              
  Lines       62629    62629              
  Branches     6308     6308              
==========================================
- Hits        41527    41412     -115     
- Misses      19453    19568     +115     
  Partials     1649     1649
Flag Coverage Δ
hive 52.07% <ø> (ø)
mysql ?
postgres ?
presto 51.91% <ø> (ø)
python 81.35% <ø> (-0.38%) ⬇️
sqlite 80.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/databases/commands/create.py 31.37% <0.00%> (-56.87%) ⬇️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/views/database/mixins.py 60.34% <0.00%> (-20.69%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/common/utils/dataframe_utils.py 85.71% <0.00%> (-7.15%) ⬇️
superset/databases/api.py 87.98% <0.00%> (-6.01%) ⬇️
superset/databases/dao.py 94.44% <0.00%> (-5.56%) ⬇️
superset/views/database/validators.py 78.94% <0.00%> (-5.27%) ⬇️
superset/databases/schemas.py 94.27% <0.00%> (-4.20%) ⬇️
superset/db_engine_specs/mysql.py 93.97% <0.00%> (-3.62%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85c8d01...835b30d. Read the comment docs.

@lilykuang lilykuang marked this pull request as ready for review February 4, 2022 18:55
@lilykuang lilykuang requested a review from a team as a code owner February 4, 2022 18:55
@lilykuang lilykuang requested a review from suddjian February 4, 2022 18:55
suddjian
suddjian reviewed Feb 7, 2022
View reviewed changes
superset/migrations/versions/5afbb1a5849b_add_embedded_dahshoard_table.py Outdated
sa.Column("created_on", sa.DateTime(), nullable=True),
sa.Column("changed_on", sa.DateTime(), nullable=True),
sa.Column("allow_domain_list", sa.Text(), nullable=True),
sa.Column("id", sa.Integer(), nullable=False),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make the id column a uuid

suddjian
suddjian approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@suddjian suddjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilykuang lilykuang merged commit 1fbdabd into master Feb 8, 2022
@lilykuang lilykuang deleted the embedded-dashboard branch February 8, 2022 08:18
ofekisr pushed a commit to nielsen-oss/superset that referenced this pull request Feb 8, 2022
@ofekisr
feat: embedded dashboard (apache#18561)
8da04e9 
* add embedded dashboard

* json

* lint

* change json to text

* uuid
@suddjian suddjian mentioned this pull request Mar 28, 2022
Merged
9 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suddjian suddjian suddjian approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lilykuang @suddjian @mistercrunch