-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add password example to dataset import API #18580
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18580 +/- ##
==========================================
- Coverage 66.29% 66.09% -0.20%
==========================================
Files 1594 1594
Lines 62623 62623
Branches 6312 6312
==========================================
- Hits 41513 41393 -120
- Misses 19459 19579 +120
Partials 1651 1651
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@dpgaspar @betodealmeida - is there some reason we don't have a single consolidated |
In this area it makes me wonder why is this nested object passed as a string instead of an object with |
Good point @ad-m - However, to change this now would probably be considered a breaking change, so perhaps not something we want to do right now. But if we do introduce a new general import endpoint, maybe we could revisit this design question. So going to merge this to make the updated doc available. |
I believe we might express that as: "oneOf": [
{ "type": "string", "deprecated": true },
{ "type": "object", "additionalProperties": true }
] to keep backward compatibility. As to the remainder, I agree that it may be worth taking this into account when implementing a new operation. |
SUMMARY
Currently the import API schema isn't super explicit on the following:
This PR adds a more verbose description of the format of the password map to clarify how this should be done:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION