Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explore): Implement chart empty states #18678

Merged
merged 4 commits into from
Feb 14, 2022

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Feb 11, 2022

SUMMARY

This PR implements chart empty states for 2 scenarios:

  1. Not all required controls have values
  2. Query returned no results

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

image

TESTING INSTRUCTIONS

  1. Create a chart
  2. Run a query that returns 0 results (for example set time range for last 5 minutes)
  3. Remove required controls

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CC @kasiazjc

https://app.shortcut.com/preset/story/36403/explore-empty-states

@kgabryje kgabryje requested a review from villebro February 11, 2022 16:04
@kgabryje kgabryje changed the title Feat/chart empty states feat(explore): Implement chart empty states Feb 11, 2022
@kgabryje kgabryje force-pushed the feat/chart-empty-states branch from 5d7b1fd to e16438f Compare February 11, 2022 16:59
@pull-request-size pull-request-size bot added size/M and removed size/L labels Feb 11, 2022
@kgabryje kgabryje requested a review from rusackas February 11, 2022 17:02
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@kgabryje kgabryje force-pushed the feat/chart-empty-states branch from e16438f to c60749f Compare February 14, 2022 09:52
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #18678 (1190616) into master (8d6aff3) will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18678      +/-   ##
==========================================
+ Coverage   66.32%   66.35%   +0.03%     
==========================================
  Files        1619     1619              
  Lines       62939    62943       +4     
  Branches     6341     6345       +4     
==========================================
+ Hits        41742    41767      +25     
+ Misses      19545    19521      -24     
- Partials     1652     1655       +3     
Flag Coverage Δ
javascript 51.35% <66.66%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/chart/ChartRenderer.jsx 44.89% <ø> (ø)
superset-frontend/src/chart/Chart.jsx 51.78% <50.00%> (-0.07%) ⬇️
...perset-ui-core/src/chart/components/SuperChart.tsx 100.00% <100.00%> (ø)
...nd/src/explore/components/DataTablesPane/index.tsx 73.68% <0.00%> (-1.59%) ⬇️
...erset-frontend/src/components/EmptyState/index.tsx 61.53% <0.00%> (+61.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d6aff3...1190616. Read the comment docs.

@kgabryje kgabryje merged commit 167e18e into apache:master Feb 14, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants