fix(altered-modal): displayed the metric value in altered modal correctly

[prosdev0107]

SUMMARY

Altered Modal Doesn't Show Metrics Properly

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[geido]

Hello @prosdev0107 thanks for the PR. There are some linting issues to fix. Also, I don't think you need to tick the "Changes UI" checkbox in the PR description as that is intended for changes that affect the UI, in this case, this is just a fix of standard behavior.

[rusackas]

Hello @prosdev0107 thanks for the PR. There are some linting issues to fix. Also, I don't think you need to tick the "Changes UI" checkbox in the PR description as that is intended for changes that affect the UI, in this case, this is just a fix of standard behavior.

Agreed on the checkbox, though I appreciate over-checking rather than under-checking :)

To run the linter locally, just run npm run lint-fix from within the superset-frontend folder you can also install the pre-commit hooks if you'd like (I would need to dig up the command if so, since I don't remember it offhand)

[rusackas]

LGTM

[rusackas]

Approved and waiting for CI. As with all fix PRs, it'd be great if there were a test. Let me know if that looks like a reasonably easy addition here.

[codecov]

Codecov Report

Merging #18813 (bb27062) into master (c8df849) will increase coverage by 0.00%.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##           master   #18813   +/-   ##
=======================================
  Coverage   66.31%   66.31%           
=======================================
  Files        1620     1620           
  Lines       63075    63090   +15     
  Branches     6370     6375    +5     
=======================================
+ Hits        41827    41837   +10     
- Misses      19591    19594    +3     
- Partials     1657     1659    +2     

Flag	Coverage Δ
javascript	51.25% <33.33%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...components/AlteredSliceTag/AlteredSliceTagMocks.js	100.00% <ø> (ø)
...-frontend/src/components/AlteredSliceTag/index.jsx	87.69% <33.33%> (-2.64%)	⬇️
...perset-frontend/src/views/components/MenuRight.tsx	80.00% <0.00%> (-0.49%)	⬇️
superset-frontend/src/views/App.tsx	0.00% <0.00%> (ø)
...frontend/src/SqlLab/components/ResultSet/index.tsx	50.73% <0.00%> (ø)
...s/legacy-plugin-chart-country-map/src/countries.ts	100.00% <0.00%> (ø)
...board/components/nativeFilters/FilterBar/index.tsx	69.82% <0.00%> (ø)
...lLab/components/ExploreCtasResultsButton/index.jsx
...lLab/components/ExploreCtasResultsButton/index.tsx	8.33% <0.00%> (ø)
...-frontend/src/components/CopyToClipboard/index.jsx	96.00% <0.00%> (+0.34%)	⬆️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8df849...bb27062. Read the comment docs.