From cfd99b716ea914272b2f6bcb225aba18e35b33ad Mon Sep 17 00:00:00 2001 From: Talyor Chen Date: Wed, 23 Feb 2022 08:09:10 -0500 Subject: [PATCH 1/2] fix(nested-tab-available): make the another tabs into one tabs available --- .../src/dashboard/util/getDropPosition.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/superset-frontend/src/dashboard/util/getDropPosition.js b/superset-frontend/src/dashboard/util/getDropPosition.js index 49c70dc9e593e..7a21a74b6aeab 100644 --- a/superset-frontend/src/dashboard/util/getDropPosition.js +++ b/superset-frontend/src/dashboard/util/getDropPosition.js @@ -55,13 +55,13 @@ export default function getDropPosition(monitor, Component) { } // TODO need a better solution to prevent nested tabs - if ( - draggingItem.type === TABS_TYPE && - component.type === TAB_TYPE && - componentDepth === 2 - ) { - return null; - } + // if ( + // draggingItem.type === TABS_TYPE && + // component.type === TAB_TYPE && + // componentDepth === 2 + // ) { + // return null; + // } const validChild = isValidChild({ parentType: component.type, From bd0f26b6bc959e94c9462455817a20c25ed11609 Mon Sep 17 00:00:00 2001 From: Talyor Chen Date: Thu, 3 Mar 2022 14:05:38 -0500 Subject: [PATCH 2/2] fix(netsted-tab): remove code of disable nested tab --- superset-frontend/src/dashboard/util/getDropPosition.js | 9 --------- 1 file changed, 9 deletions(-) diff --git a/superset-frontend/src/dashboard/util/getDropPosition.js b/superset-frontend/src/dashboard/util/getDropPosition.js index 7a21a74b6aeab..81cbc48f46941 100644 --- a/superset-frontend/src/dashboard/util/getDropPosition.js +++ b/superset-frontend/src/dashboard/util/getDropPosition.js @@ -54,15 +54,6 @@ export default function getDropPosition(monitor, Component) { return null; } - // TODO need a better solution to prevent nested tabs - // if ( - // draggingItem.type === TABS_TYPE && - // component.type === TAB_TYPE && - // componentDepth === 2 - // ) { - // return null; - // } - const validChild = isValidChild({ parentType: component.type, parentDepth: componentDepth,