fix: ensure validation for db modal for googlesheets

[pkdotson]

SUMMARY

This pr fixes possibly fixes an issue where the validation for name or googlesheet api could be negated as truthy when trying to connect a gsheet. This is because the two of the same set state methods not separated by async method creating a race condition being returned from the hook.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

after

Screen.Recording.2022-03-03.at.3.39.31.PM.mov

TESTING INSTRUCTIONS

Go to gsheets database modal and try to connect a gsheet without name or url. It should not proceed to the next step without both being valid.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #19018 (d87934c) into master (150fd0d) will decrease coverage by 0.04%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master   #19018      +/-   ##
==========================================
- Coverage   66.58%   66.54%   -0.05%     
==========================================
  Files        1641     1641              
  Lines       63524    63500      -24     
  Branches     6421     6441      +20     
==========================================
- Hits        42299    42255      -44     
- Misses      19548    19582      +34     
+ Partials     1677     1663      -14     

Flag	Coverage Δ
javascript	51.28% <33.33%> (-0.10%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/views/CRUD/hooks.ts	47.15% <33.33%> (ø)
...ts/nativeFilters/FilterBar/FilterControls/utils.ts	25.00% <0.00%> (-45.00%)	⬇️
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx	64.67% <0.00%> (-14.73%)	⬇️
...d/components/nativeFilters/FilterCard/ScopeRow.tsx	58.82% <0.00%> (-13.91%)	⬇️
...Filters/FilterBar/FilterControls/FilterControl.tsx	70.96% <0.00%> (-11.18%)	⬇️
...d/src/filters/components/Time/TimeFilterPlugin.tsx	47.05% <0.00%> (-9.20%)	⬇️
...tend/src/filters/components/Time/transformProps.ts	50.00% <0.00%> (-7.15%)	⬇️
...oard/components/nativeFilters/FilterCard/Styles.ts	80.00% <0.00%> (-4.62%)	⬇️
...mponents/nativeFilters/FiltersConfigModal/utils.ts	46.96% <0.00%> (-4.27%)	⬇️
...rset-frontend/src/explore/components/SaveModal.tsx	63.63% <0.00%> (-2.50%)	⬇️
... and 49 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 150fd0d...d87934c. Read the comment docs.

[michael-s-molina]

@pkdotson Why is the whole screen re-rendering when you click on Connect and get a validation error? It's blinking and showing the loading indicator. Is it possible to improve this behavior?

[pkdotson]

@pkdotson Why is the whole screen re-rendering when you click on Connect and get a validation error? It's blinking and showing the loading indicator. Is it possible to improve this behavior?

Hi Michael I think this is just a combination of the connection being fast on my local and how it was originally designed. I'll bring this up to the team to see if this can be looked into.

[pkdotson]

/testenv up

[github-actions]

@pkdotson Ephemeral environment spinning up at http://54.214.148.138:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.