fix: custom SQL in Sort By Breaks Bar Chart

[diegomedina248]

SUMMARY

When adding custom SQL to the Sort by field, the Bar chart results return, but the visualization doesn’t render

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

1. Create a bar chart
2. Add a sum() to the metrics, a text column to Series, a text column to Breakdown
3. Manually add a Sort by, typing in one of the column names from the Series or Breakdown fields
4. Run the query

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #19069 (7d0f4de) into master (f9c7405) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

❗ Current head 7d0f4de differs from pull request most recent head 32099cf. Consider uploading reports for the commit 32099cf to get more accurate results

@@            Coverage Diff             @@
##           master   #19069      +/-   ##
==========================================
- Coverage   66.50%   66.32%   -0.18%     
==========================================
  Files        1642     1642              
  Lines       63442    63442              
  Branches     6439     6439              
==========================================
- Hits        42191    42081     -110     
- Misses      19582    19691     +109     
- Partials     1669     1670       +1     

Flag	Coverage Δ
hive	?
mysql	81.81% <100.00%> (ø)
postgres	81.86% <100.00%> (ø)
presto	?
python	81.94% <100.00%> (-0.35%)	⬇️
sqlite	81.55% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/viz.py	58.26% <100.00%> (ø)
superset/db_engines/hive.py	0.00% <0.00%> (-85.19%)	⬇️
superset/db_engine_specs/hive.py	70.00% <0.00%> (-15.77%)	⬇️
superset/db_engine_specs/presto.py	83.47% <0.00%> (-5.65%)	⬇️
superset-frontend/src/views/components/Menu.tsx	56.41% <0.00%> (-2.57%)	⬇️
superset/connectors/sqla/models.py	88.87% <0.00%> (-1.24%)	⬇️
superset/db_engine_specs/base.py	89.14% <0.00%> (-0.34%)	⬇️
superset/models/core.py	88.67% <0.00%> (-0.25%)	⬇️
superset/utils/core.py	90.13% <0.00%> (-0.13%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9c7405...32099cf. Read the comment docs.

[rusackas]

If you happen to capture before/after GIFs/videos/screenshots for changes like this, it can often help with the repro of this issue, and provide historical context we sometimes refer back to.

[rusackas]

/testenv up

[github-actions]

@rusackas Ephemeral environment spinning up at http://35.87.115.171:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[rusackas]

LGTM, and seems to be working in testing. Just pinging @villebro for a quick 👀 in case he knows of any particular reasoning for the way it was before.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.