Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Logic for showing extension in Global Nav #19158

Merged
merged 5 commits into from
Mar 16, 2022
Merged

fix: Logic for showing extension in Global Nav #19158

merged 5 commits into from
Mar 16, 2022

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Mar 15, 2022

SUMMARY

Before we had back logic for showing the allowed extensions in the global nav, we've moved it by simplifying where the logic lives in the dropdown nav

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh force-pushed the fix-allowed-extensions branch from 9e8ee9d to 6a2b239 Compare March 15, 2022 17:08
pkdotson
pkdotson approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Mar 15, 2022 •
edited
Loading

Codecov Report

Merging #19158 (527a7af) into master (bb618a4) will decrease coverage by 0.15%.
The diff coverage is 33.33%.

❗ Current head 527a7af differs from pull request most recent head d8dfb81. Consider uploading reports for the commit d8dfb81 to get more accurate results

@@            Coverage Diff             @@
##           master   #19158      +/-   ##
==========================================
- Coverage   66.55%   66.40%   -0.16%     
==========================================
  Files        1646     1646              
  Lines       63632    63632              
  Branches     6476     6476              
==========================================
- Hits        42353    42252     -101     
- Misses      19597    19698     +101     
  Partials     1682     1682
Flag Coverage Δ
hive 52.53% <100.00%> (ø)
mysql ?
postgres ?
presto 52.37% <100.00%> (ø)
python 82.03% <100.00%> (-0.33%) ⬇️
sqlite 81.67% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/views/CRUD/utils.tsx 62.71% <0.00%> (ø)
superset-frontend/src/views/components/Menu.tsx 58.97% <ø> (ø)
...perset-frontend/src/views/components/MenuRight.tsx 65.71% <0.00%> (ø)
superset/utils/async_query_manager.py 82.24% <100.00%> (ø)
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/databases/commands/create.py 64.70% <0.00%> (-27.46%) ⬇️
superset/views/database/mixins.py 60.34% <0.00%> (-20.69%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/common/utils/dataframe_utils.py 85.71% <0.00%> (-7.15%) ⬇️
superset/databases/api.py 87.98% <0.00%> (-6.01%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb618a4...d8dfb81. Read the comment docs.

@hughhhh hughhhh force-pushed the fix-allowed-extensions branch from 6a2b239 to 9723ef0 Compare March 15, 2022 17:44
eschutho
eschutho reviewed Mar 15, 2022
View reviewed changes
superset-frontend/src/views/CRUD/utils.tsx Outdated
perm: Array<any> | string | undefined | boolean,
cons: Array<any>,
) => {
export const checkUploadExtensions = (perm: Array<any>, cons: Array<any>) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, but I think an array of strings is the only type that would make sense, if you want to be more specific.

@hughhhh hughhhh merged commit 181ecf4 into master Mar 16, 2022
@sadpandajoe
Copy link
Member

🏷️ preset:2022.11

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Mar 17, 2022
@hughhhh @sadpandajoe
fix: Logic for showing extension in Global Nav (apache#19158)
4829d04 
* fix logic for checking extensions

* add specific types

* fix lint

(cherry picked from commit 181ecf4)
villebro pushed a commit that referenced this pull request Apr 3, 2022
@hughhhh @villebro
fix: Logic for showing extension in Global Nav (#19158)
ca0c12f 
* fix logic for checking extensions

* add specific types

* fix lint

(cherry picked from commit 181ecf4)
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the fix-allowed-extensions branch March 26, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkdotson pkdotson pkdotson approved these changes

@eschutho eschutho eschutho approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset:2022.11 size/S 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hughhhh @sadpandajoe @eschutho @pkdotson @mistercrunch @villebro